[17:04:09] im unsure if its always been like this and ive never noticed it or if its a semi-new issue but in #cvn-wp-en theres a missing space between the diff link and edit summary for the large removal message [17:06:24] it also seems to only be on the one for ip users [20:12:06] owuh: the messages are in Git. Let's see... [20:12:53] https://github.com/wikimedia/labs-countervandalism-CVNBot/blob/master/src/Console.msgs [20:13:49] That's for most bots and channels [20:13:51] https://github.com/wikimedia/labs-countervandalism-cvn-infrastructure/blob/master/CVNBot-msgs-swmt.msgs [20:14:03] That's for cvn-sw [20:14:54] cvn-wp-en uses the first one (default) [20:17:02] Yep, for blacklisted actors, large removal is missing a space it seems. https://github.com/wikimedia/labs-countervandalism-CVNBot/blob/v4.0.4/src/Console.msgs#L82 [20:18:05] Thee greylist version a few lines down as well [20:18:35] And Ip users [20:18:39] Those three [20:18:58] owuh: do you want to submit a git patch to Gerrit? [20:19:41] https://gerrit.wikimedia.org/g/labs/countervandalism/CVNBot [20:19:43] https://gerrit-patch-uploader.toolforge.org/ [20:20:03] Thats easiest. Can use your wiki account. No gerrit or ssh account needed. [21:02:09] (03PS1) 10Gerrit Patch Uploader: fix spacing in large removal message [labs/countervandalism/CVNBot] - 10https://gerrit.wikimedia.org/r/1122246 [21:02:09] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [labs/countervandalism/CVNBot] - 10https://gerrit.wikimedia.org/r/1122246 (owner: 10Gerrit Patch Uploader) [21:02:37] i *think* i did it right [21:05:47] Krinkle pinging you because im unsure if anything needs to be done on your part [21:13:28] (03PS2) 10Krinkle: Console.msgs: Fix spacing in "Large removal" messages [labs/countervandalism/CVNBot] - 10https://gerrit.wikimedia.org/r/1122246 (owner: 10Gerrit Patch Uploader) [21:13:52] owuh: I think you missed one, the "IP editor" one that you originally reported. [21:14:35] To update the patch, make sure to include the Change-Id in your commit message [21:14:57] I'll merge it after that [21:16:15] the change id is the one that starts with "I6bf0" right? [21:18:14] (03PS3) 10Gerrit Patch Uploader: Fix more spacing in large removal message [labs/countervandalism/CVNBot] - 10https://gerrit.wikimedia.org/r/1122246 [21:18:15] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [labs/countervandalism/CVNBot] - 10https://gerrit.wikimedia.org/r/1122246 (owner: 10Gerrit Patch Uploader) [21:45:23] (03PS4) 10Krinkle: Console.msgs: Fix spacing in "Large removal" messages [labs/countervandalism/CVNBot] - 10https://gerrit.wikimedia.org/r/1122246 (owner: 10Gerrit Patch Uploader) [21:45:25] (03CR) 10Krinkle: [C:03+2] Console.msgs: Fix spacing in "Large removal" messages [labs/countervandalism/CVNBot] - 10https://gerrit.wikimedia.org/r/1122246 (owner: 10Gerrit Patch Uploader) [21:45:54] (03Merged) 10jenkins-bot: Console.msgs: Fix spacing in "Large removal" messages [labs/countervandalism/CVNBot] - 10https://gerrit.wikimedia.org/r/1122246 (owner: 10Gerrit Patch Uploader) [21:47:55] awesome, thanks [21:52:52] AntiComposite: hm.. looking at a few permission issues on cvn-app10 [21:52:54] -rw-r--r-- 1 anticomposite project-cvn 79 Jan 7 2023 .gitignore [21:53:02] in /srv/cvn/git/CVNBot [21:53:07] fatal: Unable to create '/srv/cvn/git/CVNBot/.git/index.lock': Permission denied [21:53:20] In theory, the umask we set is meant to prevent that [21:53:31] by making sure owner+group are always the same (and we're both in the group) [21:53:57] What do you get when you run `umask` from a shell on cvn-app10? [21:54:15] 0002 [21:54:18] whatever happened it wasnt me [21:55:11] or, in symbolic form, u=rwx,g=rwx,o=rx [21:58:01] AntiComposite: same for me. I wonder why those got created that way [21:58:16] AntiComposite: can you e.g. touch foobar.txt somewhere and see how that gets created? [21:58:29] -rw-rw-r-- 1 krinkle project-cvn 0 Feb 24 21:58 krinkle.txt [21:58:35] 664, as it should be [21:59:35] same here [22:00:57] ok, I'll just sudo rm -rf && git checkout . and assume it won't happen again :) [22:01:15] error: update_ref failed for ref 'HEAD': cannot lock ref 'HEAD': Unable to create '/srv/cvn/git/CVNBot/.git/refs/heads/master.lock': Permission denied [22:01:21] ugh, more indirect stuff down in .git [22:01:48] * Krinkle copies some commands from https://gerrit.wikimedia.org/g/operations/puppet/+/1cd1e5dd6f73a34a22266ee221f28be03b5ea9d6/modules/profile/files/mediawiki/deployment/fix-staging-perms.sh [22:04:55] `git config --get core.sharedRepository` is false, so it should fall back to the umask within .git [23:12:27] owuh: I've deployed the update to CVNBot1, should be good now!