[04:59:32] (03PS24) 10Krinkle: [WIP] Rewrite CVNBot in python [labs/countervandalism/CVNBot] - 10https://gerrit.wikimedia.org/r/1324908 (https://phabricator.wikimedia.org/T327136) [05:00:00] (03CR) 10CI reject: [V:04-1] [WIP] Rewrite CVNBot in python [labs/countervandalism/CVNBot] - 10https://gerrit.wikimedia.org/r/1324908 (https://phabricator.wikimedia.org/T327136) (owner: 10Krinkle) [05:05:08] !log Disable stillalive cron for CVNBot12 (cvn-wp-nl), replace with manual run of pycvnbot https://gerrit.wikimedia.org/r/1324908 [05:05:09] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Cvn/SAL [05:28:02] (03PS25) 10Krinkle: [WIP] Rewrite CVNBot in python [labs/countervandalism/CVNBot] - 10https://gerrit.wikimedia.org/r/1324908 (https://phabricator.wikimedia.org/T327136) [05:28:30] (03CR) 10CI reject: [V:04-1] [WIP] Rewrite CVNBot in python [labs/countervandalism/CVNBot] - 10https://gerrit.wikimedia.org/r/1324908 (https://phabricator.wikimedia.org/T327136) (owner: 10Krinkle) [05:40:50] (03PS1) 10Krinkle: Create template for CVNBot 5.x (pycvnbot) and monitor cvn-wp-nl [labs/countervandalism/stillalive] - 10https://gerrit.wikimedia.org/r/1332431 (https://phabricator.wikimedia.org/T327136) [05:40:52] (03PS1) 10Krinkle: Switch CVNBot11 to pycvnbot [labs/countervandalism/stillalive] - 10https://gerrit.wikimedia.org/r/1332432 (https://phabricator.wikimedia.org/T327136) [05:41:11] (03CR) 10CI reject: [V:04-1] Create template for CVNBot 5.x (pycvnbot) and monitor cvn-wp-nl [labs/countervandalism/stillalive] - 10https://gerrit.wikimedia.org/r/1332431 (https://phabricator.wikimedia.org/T327136) (owner: 10Krinkle) [05:41:20] (03CR) 10CI reject: [V:04-1] Switch CVNBot11 to pycvnbot [labs/countervandalism/stillalive] - 10https://gerrit.wikimedia.org/r/1332432 (https://phabricator.wikimedia.org/T327136) (owner: 10Krinkle) [05:44:16] (03PS1) 10Krinkle: build: Fix PHP 8.3 build [labs/countervandalism/stillalive] - 10https://gerrit.wikimedia.org/r/1332434 [05:44:56] (03CR) 10Krinkle: [C:03+2] build: Fix PHP 8.3 build [labs/countervandalism/stillalive] - 10https://gerrit.wikimedia.org/r/1332434 (owner: 10Krinkle) [05:45:11] (03PS2) 10Krinkle: Create template for CVNBot 5.x (pycvnbot) and monitor cvn-wp-nl [labs/countervandalism/stillalive] - 10https://gerrit.wikimedia.org/r/1332431 (https://phabricator.wikimedia.org/T327136) [05:45:14] (03CR) 10Krinkle: [C:03+2] Create template for CVNBot 5.x (pycvnbot) and monitor cvn-wp-nl [labs/countervandalism/stillalive] - 10https://gerrit.wikimedia.org/r/1332431 (https://phabricator.wikimedia.org/T327136) (owner: 10Krinkle) [05:45:17] (03PS2) 10Krinkle: Switch CVNBot11 to pycvnbot [labs/countervandalism/stillalive] - 10https://gerrit.wikimedia.org/r/1332432 (https://phabricator.wikimedia.org/T327136) [05:45:20] (03CR) 10Krinkle: [C:03+2] Switch CVNBot11 to pycvnbot [labs/countervandalism/stillalive] - 10https://gerrit.wikimedia.org/r/1332432 (https://phabricator.wikimedia.org/T327136) (owner: 10Krinkle) [05:45:53] (03Merged) 10jenkins-bot: build: Fix PHP 8.3 build [labs/countervandalism/stillalive] - 10https://gerrit.wikimedia.org/r/1332434 (owner: 10Krinkle) [05:45:54] (03Merged) 10jenkins-bot: Create template for CVNBot 5.x (pycvnbot) and monitor cvn-wp-nl [labs/countervandalism/stillalive] - 10https://gerrit.wikimedia.org/r/1332431 (https://phabricator.wikimedia.org/T327136) (owner: 10Krinkle) [05:45:59] (03Merged) 10jenkins-bot: Switch CVNBot11 to pycvnbot [labs/countervandalism/stillalive] - 10https://gerrit.wikimedia.org/r/1332432 (https://phabricator.wikimedia.org/T327136) (owner: 10Krinkle) [05:54:37] 10CVNBot, 13Patch-For-Review: Rewrite CVNBot in another language - https://phabricator.wikimedia.org/T327136#12268552 (10Krinkle) What I'm doing: * On the server, make a backup of the database just in case. `CVNBot12$ cp Lists.sqlite Lists.sqlite.bak` * Edit CVNBot.ini and set `logsyslog=1`. `CVNBot12$ edit C... [06:03:30] 10CVNBot, 13Patch-For-Review: Rewrite CVNBot in another language - https://phabricator.wikimedia.org/T327136#12268554 (10Krinkle) Plan: 1. [x] Switch cvn-commons-uploads (CVNBot11) and cvn-wp-nl (CVNBot12). This will test a heavy feed (Commons), and a localised non-English feed (Dutch). 2. Let cvn-commons-upl... [06:04:12] AntiComposite: fyi, I still have a bit more review to do, but it seems stable enough to switch two bots and get some practical experience for whatever edge cases I didn't test manaully. [06:05:19] I no longer consider the patch LLM-generated for what it's worth. I've basically reviewed and refactored everthing to make it my own. I've used the dump Amir provided basically as a batch-Google/StackOverflow-search for what certain C# idioms translate to in Python. [06:05:57] Given I'm not super fluent in Python myself, the irony is that it is quite possible I've made some code "worse" in the process or less idiomatic to an experience pythonist, but at least it matches my mental model and intuition. [06:06:30] Every line and test has been rewritten or confirm to be what I would have wanted it to be, but sped up with some of the suggestions from there. [06:07:34] I've spent 2h a day the last 2-3 weeks slowly churning through each line. Removed a bunch of silly porting of logic that isn't applicable. Found and fixed a bunch of bugs caused by the port. Also found and fixed a bunch of pre-existing bugs that I discovered in the process through code that was already weird to begin with. [06:08:43] s/weird/wrong/ [06:16:01] (03PS26) 10Krinkle: [WIP] Rewrite CVNBot in python [labs/countervandalism/CVNBot] - 10https://gerrit.wikimedia.org/r/1324908 (https://phabricator.wikimedia.org/T327136) [06:16:29] (03CR) 10CI reject: [V:04-1] [WIP] Rewrite CVNBot in python [labs/countervandalism/CVNBot] - 10https://gerrit.wikimedia.org/r/1324908 (https://phabricator.wikimedia.org/T327136) (owner: 10Krinkle) [20:14:23] Krinkle, sounds good [21:37:57] (03PS27) 10Krinkle: [WIP] Rewrite CVNBot in python [labs/countervandalism/CVNBot] - 10https://gerrit.wikimedia.org/r/1324908 (https://phabricator.wikimedia.org/T327136) [21:38:26] (03CR) 10CI reject: [V:04-1] [WIP] Rewrite CVNBot in python [labs/countervandalism/CVNBot] - 10https://gerrit.wikimedia.org/r/1324908 (https://phabricator.wikimedia.org/T327136) (owner: 10Krinkle)