[04:52:09] <TimStarling>	 Pchelolo: RollbackPageTest is failing for me against git master
[04:52:17] <TimStarling>	 I'm at the second stage of debugging it
[04:52:47] <TimStarling>	 (1. how can this possibly fail, 2. how can this possibly work, 3. actual understanding)
[04:56:52] <TimStarling>	 in testAuthorize(), it makes a fake user: new UserIdentityValue( 9999, 'Petr' ), and calls authorizeRollback() with that user
[04:58:42] <TimStarling>	 that ends up in autopromote, it loads the user, which doesn't exist, so it overwrites the user name and ID
[04:58:59] <TimStarling>	 hmm, is it possible we're not catching notices in CI?
[04:59:22] <TimStarling>	 it raises a notice due to the username changing unexpectedly
[05:00:50] <TimStarling>	 nope, with error_reporting=0 it still fails, just a bit later
[05:25:22] <TimStarling>	 ahh, it's DevelopmentSettings.php
[05:25:41] <TimStarling>	 it has $wgRateLimits = []; and that's enough to make it work
[05:25:51] * TimStarling advances to stage 3
[05:50:46] <TimStarling>	 filed https://phabricator.wikimedia.org/T284804
[16:48:16] <ebernhardson>	 I'm intending to revert https://gerrit.wikimedia.org/r/c/mediawiki/core/+/697673 (until it can be fixed) unless someone has reason otherwise. it introduced recursive service instantiation for sessions using the BotPasswordSessionProvider