[00:00:57] <TimStarling>	 my only question is whether page_content_model is always correct, and maybe Daniel has a sense for that, but other than that, I think your change looks fine
[00:01:18] <Pchelolo>	 ok. I'll try to verify that page_content_model is always set and is correct and write some tests maybe
[00:01:41] <TimStarling>	 hmm... content models can change can't they?
[00:02:04] <TimStarling>	 maybe also think about old revision views, old revision edits, reverts, etc.
[00:02:05] <Pchelolo>	 they can
[00:04:57] <Pchelolo>	 ok. thank you. will get back when I'm sure 2 methods return the same thing
[00:28:57] <legoktm>	 there's a lot of weird things when content models change
[00:29:46] <legoktm>	 the weirdest is when you move a page into a new namespace so the "default content model" changes, so you then populate all the null rows with the correct value
[00:53:12] <inductiveload>	 what's the right tag for a task on phab for adjusting the HTML on the diff pages?
[00:53:41] <inductiveload>	 #mediawiki-page-history?
[00:58:40] <legoktm>	 inductiveload: MediaWiki-Page-diffs
[00:59:04] <legoktm>	 which you already found :)
[00:59:17] <inductiveload>	 is -history wrong?
[01:00:21] <legoktm>	 yeah, I removed it
[01:00:38] <inductiveload>	 thanks ^_^
[19:39:49] <RhinosF1>	 Pchelolo: I've being seeing premature warnings on 1.36 simmilar so is https://gerrit.wikimedia.org/r/c/mediawiki/core/+/702448/2/maintenance/includes/Maintenance.php backport able?
[19:40:20] <Pchelolo>	 RhinosF1: yes, it's definitely backportable. 
[19:40:37] <Pchelolo>	 didn't have any review yet, so let's see what folks say
[19:40:58] <RhinosF1>	 Pchelolo: grabbing a trace but if approved that would be good
[20:01:32] <RhinosF1>	 Pchelolo: https://www.irccloud.com/pastebin/3yABMw9B
[20:02:08] <Pchelolo>	 still happening with the patch?
[20:02:29] <RhinosF1>	 Haven't tried
[20:02:40] <RhinosF1>	 I can hack test3 later
[20:04:38] <Pchelolo>	 oh, yeah, I think these all are cause by the same call - it's just MWServices::getInstance initialized some services which call to MWServices::getInstance etc. and we get 3 warnings for 1 call
[20:13:08] <MatmaRex>	 hi, i have a question about parsing wikitext, revisions, and replica databases. related to https://phabricator.wikimedia.org/T285895
[20:14:15] <RhinosF1>	 Pchelolo: will test fix soon
[20:14:20] <MatmaRex>	 if i have a RevisionRecord object, which was fetched from primary (using IDBAccessObject::READ_LATEST), and i call ->getContent(…) on it – will that also fetch the content from the primary database?
[20:15:40] <MatmaRex>	 i'll push a patch for review in a moment, if that makes it easier to answer
[20:18:45] <Pchelolo>	 MatmaRex: So, the revision slots will be fetched, possibly lazily, using the same $queryFlags as you have passed to get the revision. 
[20:19:18] <Pchelolo>	 then actual content of the slots might also me fetched lazily, and that as well carries over the query flags
[20:20:37] <Pchelolo>	 but all that only gets you to the blob_address in external store.
[20:21:17] <MatmaRex>	 thanks
[20:21:39] <MatmaRex>	 i have no idea how external store works… but it should have the data, right? if the revision points to it?
[20:22:19] <Pchelolo>	 yup. With external store I am reaching my limits here, but it also does have primary/replica
[20:22:32] <Pchelolo>	 and I think that the actual blob is fetched from a replica there
[20:22:58] <Pchelolo>	 even if you fetched the revision from primary. I got to this by reading the code, not 100% sure I'm correct
[20:23:27] <Pchelolo>	 cc me on the patch, might be easier to help
[20:23:37] <Pchelolo>	 ppchelko is my gerrit
[20:25:57] <MatmaRex>	 Pchelolo: the patch is https://gerrit.wikimedia.org/r/702457
[20:26:11] <MatmaRex>	 it's not working for me locally at the moment, i'm debugging why, but it should give you an idea of what i want to do
[20:26:30] <MatmaRex>	 (also, thank you)
[20:31:30] <MatmaRex>	 (it should work now in PS2)
[20:33:16] <Pchelolo>	 I'll respond on the patch
[20:34:27] <MatmaRex>	 thanks! :)
[21:05:54] <RhinosF1>	 Pchelolo: given you C+1