[15:21:43] Reedy: I'm updating wikimeida/miinfy in REL1_36, and noticing monolog/monolog updates are coming along. [15:21:51] Any reason this isn't pinned? [15:22:06] I innitially discarded the diff as being lock-only and just a dev dep, but it's actualy installed as well [15:22:16] Krinkle: monolog/monolog isn't required [15:22:28] uh [15:22:30] but we vendor it.. [15:22:40] wikimedia/shellbox brought it in [15:22:46] without pinning it [15:23:10] Aha [15:23:16] including in REL1_36 [15:23:20] not sure what we want to do there [15:24:06] Make a commit pinning it as it's included... [15:24:11] And then make your change ontop of it [15:26:49] Of course, with shellbox in MW core... There's literally no point it only being in require-dev [15:27:05] So we should probably fix that too, seperately [15:34:39] Krinkle: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/708551 [15:35:36] Oh, I see. right. So it's not a rel-only thing [15:36:36] https://gerrit.wikimedia.org/r/c/mediawiki/vendor/+/708552 fixes it in REL1_36 [15:36:51] hey I called dibs on that one [15:37:11] hah, yours came first indeed [15:37:13] * Reedy abandons [15:38:52] ok, let's see if the core commits for minify actually pass the way they should