[18:06:02] <majavah>	 is there a better way to inject config variables to a ObjectFactory object (hook handler in this case) than injecting the MainConfig service? no way to get a serviceoptions or something like that?
[21:38:17] <Krinkle>	 legoktm: is ability-shell not something new? I've never seen it before..
[21:39:36] <legoktm>	 https://gerrit.wikimedia.org/r/c/mediawiki/core/+/467094 merged in April 2019
[21:40:11] <Krinkle>	 https://github.com/wikimedia/mediawiki-extensions-SyntaxHighlight_GeSHi/commit/b5a904e2ecfab56f946215c30cb69945c726432a
[21:40:35] <Krinkle>	 so web and CLI installer both gracefully skip it?
[21:40:47] <Krinkle>	 well, I guess CLI installer is unlikely
[21:41:02] <Krinkle>	 alright, well, I guess someone would have complained by now if it was confusing to them
[21:41:07] <legoktm>	 I only tested web, but CLI should behave in the same way or throw an error
[21:41:44] <Krinkle>	 I thought you had enforced it just a few patches earlier in the same repo and then removing this, but oh well, nvm :)
[21:41:52] <legoktm>	 At the time I was also thinking of adding an ability-http but maybe that got skipped because I couldn't find a use case
[21:43:20] <Krinkle>	 right, given curl optional
[21:45:10] <legoktm>	 HttpRequestFactory::canMakeRequests() is function_exists( 'curl_init' ) || wfIniGetBool( 'allow_url_fopen' )
[21:46:16] <legoktm>	 I guess E:Citoid and stuff like that are mostly/entirely useless if you can't connect to an external service
[21:49:36] <legoktm>	 I'm mostly reviewing SyntaxHighlight before Shellboxing it, interestingly it doesn't invalidate cache based on new pygments versions
[23:02:28] <Krinkle>	 yeah, we let them roll over slowly instead.
[23:02:50] <Krinkle>	 I guess in theory there could be a breaking change in its HTML or CSS contract.
[23:03:08] <Krinkle>	 its been stable for over a decade though