[00:09:12] Krinkle: we need a UI for it, I've been thinking about that [00:09:52] for parsoid I've been using excimer to make line-level profiles, which is a nice tool [00:10:33] the UI is a tab-separated text file with line numbers and sample counts, so not ideal for people other than me [00:11:15] also flame graphs are cute, but when you get serious you often want to be able to aggregate in a few different ways, and you need to be able to get numbers more easily [00:15:20] hm, I suppose composer has to be bundling symfony somehow so it doesn't matter what version we are using. [00:17:09] their lockfile suggests they use symfony/console 2.8, even on composer master [00:18:01] though they do support newer versions, so one could mess with the phar file [00:18:27] but then calling phpunit directly might be slightly less effort [00:46:02] tgr: I don't know if it bundles it, it might. but at best I imagine it has a global /usr/local/lib or some such where all globally installed composer packages are on any given system, so wha's in the local vendor/ wouldn't affect it. [00:46:32] I'm assuming here that composer exec is indeed as it appears a shell sub process [00:47:05] and I'm assuming that it is indeec composer who is reading those late parameters proactively before starting that sub process [00:47:24] once we're inside phpunit or phpcs the ship has sailed and the mistake is made [00:47:54] yeah, I'm using vendor/bin/phan instead of composer exec now [00:50:27] the composer.phar definitely bundles a vendor, which has symfony/console among other things [04:15:05] * TimStarling hit the wrong button in PHPStorm and accidentally converted a 1600 line source file to lower case except where it would be syntactically incorrect to do so [04:15:39] I was lucky to spot it before uploading [04:15:42] not sure what button that was [06:02:03] the "my shift key is broken" button? [07:18:48] ctrl-shift-U lowercases, I don't think it cares about syntax though [09:17:22] TimStarling: I have Shellbox conversion patches for 4 out of the remaining 5 shellouts ready for review: https://gerrit.wikimedia.org/r/q/topic:%2522boxedcommand%2522+status:open whenever you have time [09:18:10] I'm not sure what to do about VipsScaler, which has a Special:VipsTest endpoint that bypasses thumbor and still runs vips. Given that all other non-test scaling is handled by thumbor, should we just undeploy it? [09:56:21] yes [17:29:12] legoktm: Filed T290759. [17:29:12] T290759: Undeploy VipsScaler - https://phabricator.wikimedia.org/T290759 [18:20:48] thanks :) [20:55:47] Krinkle: thanks for the +2s, I just rebased https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Score/+/716004/ [22:04:01] Amir1: I'm rebasing my shellbox patch on top of yours now, and then maybe your clean up/JSONification can be on top of mine? [22:04:51] legoktm: sure, do you have ETA when it'll be ready/merged? [22:06:20] I'll have the patch ready in about ~2 hours, merging... whenever someone has time to review it :) [22:12:06] for me the order of magnitude matters, I will work on it next week [22:17:24] :-D [22:17:37] legoktm: If you tell me it works I can review for sense… [22:29:59] ack :) [22:30:24] Amir1: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/720143 is what it looks like roughly, I'll probably find a typo somewhere when I test it in a few minutes [22:31:47] it looks nice, I'm a bit reluctant for bash script inside mediawiki [22:31:53] but it's not end of the world [22:33:58] it allows running both commands in one shellbox call so we don't have to send the djvu file twice [22:35:12] https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Score/+/refs/heads/master/scripts/generatePngAndMidi.sh is the much more complicated one that Score uses [22:37:45] okay then