[15:53:11] https://getrector.org/blog/how-to-bump-minimal-version-without-leaving-anyone-behind [16:14:29] Reedy: we've been poking at Rector for fun and profit in PET. [16:14:47] it's interesting actually could be rather useful [16:14:58] >It's fast and precise - changes 5000 files under minute. [16:15:05] Is this tested on a 5400RPM hard drive? [16:15:30] on my mac is takes like 15 minutes to run over entire core :) [16:15:46] https://gerrit.wikimedia.org/r/c/mediawiki/core/+/720474 <- made with Rector [16:16:13] Definitely pretty cool if we can make some changes like that automagically [16:17:51] there's some issues with it - like it will import all classes and there's no way to tell it not to, it's coding standards are different from ours and based of ecs and not configurable, so you need to run phpcbf to clean up after it [16:18:30] but it's pretty powerful - https://github.com/Pchelolo/wikimedia-rector/pull/2/files - this can basically clean up for us after some recent deprecation [16:25:42] ooh wait, do we have polyfills for str_starts_with etc.? i am pained every time i need to use strpos() === 0 [16:36:39] MatmaRex: Yeah, as of recently we do in master [16:37:06] https://github.com/wikimedia/mediawiki/commit/78522aea4b1dccec2f9946c42194f35a4e646d1d [16:37:41] Which reminds me... I should backport that to 1.35 and 1.36 too tbh [16:37:49] neat [16:37:51] But not for todays release