[20:18:13] Reedy: around? got a quick question, since you were looking at my WikimediaMessages patches [20:18:48] Reedy: isn't it awful how that code checks $wgDBname directly, and woud you deploy patches to make it not so? [20:53:48] Reedy: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaMessages/+/725153 https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/726052 [21:03:52] assuming Reedy is out, any chance i can convince anyone else to have a look? it would simplify my life greatly if that was merged/deployed [21:05:18] sure [21:05:26] MatmaRex: when do you want them reviewed by? [21:05:51] heh, i'll take whatever i can get [21:06:48] if you want to look now, i could backport it in the next window, but it's not urgent [21:07:21] (it's just annoying to maintain a stack of patches on top of it, that i'll have to rewrite if someone makes me rename the config variable or something) [21:07:44] >.< I was just about to ask you to do that [21:07:50] okay, good [21:07:55] i don't have any of those patches yet :D [21:08:08] "WikimediaMessagesLicensing" [21:08:18] i did WMM because WikimediaEvents does WME [21:08:27] but that was actually my first idea, i'll replace it [21:13:18] idk why that one is non-standard, everything really should follow $wg