[19:43:41] Anyone got any bright ideas why there's some PHP 8 test failure weirdness on REL1_35? [19:43:45] REL1_36+ is fine [19:44:03] https://integration.wikimedia.org/ci/job/mediawiki-quibble-composer-mysql-php80-docker/56/console [19:44:15] Mostly deprecations not being as expected... [19:45:29] https://phabricator.wikimedia.org/T274966#7639975 [19:45:34] how do I override a system message for a phpunit test case? [19:57:51] I've got a feeling we don't do that often [19:58:58] yeah :/ just a $this->editPage( 'MediaWiki:...', '...' ); doesn't seem to work [19:59:13] for context: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/758100 [20:00:20] The other tests that change MW namespace stuff would look to not be overriding/changing actual messages [20:04:18] taavi: What if you give it a user with the right rights? [20:04:24] > * @param Authority|null $performer If null, static::getTestUser()->getUser() is used. [20:04:36] I'm guessing a normal user doesn't have interface editing rights [20:17:41] Reedy: interesting idea, let's see [20:18:04] I should probably figure out why phpunit doesn't load LocalSettings on my machine, having to test these via jenkins is kind of annoying [20:18:32] How are you running it? [20:19:01] the "run tests" button in PhpStorm [20:19:10] lol [20:20:46] if wonder if you just use `composer phpunit:something` in the terminal it'll work [20:22:08] nope, same thing [20:24:19] I'm leaning towards it being a MediaWiki thing but haven't had the time to look closely enough to figure out what's actually wrong. the weird thing is that if I declare $wgServer inside $wgConf, it complains about that not being declared, otherwise it complains about not being able to access the database with the default creds even when those are [20:24:19] defined outside $wgConf [20:25:37] anyhow, even passing an UltimateAuthority to editPage() doesn't make wfMessage() return the right thing [21:04:19] taavi: the pure unit tests via composer run do not load localsettings regardless of local or CI. They're meant to be deterministic regardless of context [21:05:18] The integration tests via phpunit.php do load a bit of local state, mostly for db setup and extensions enabled, most actual settings should be ignored by most tests eg we tend to mock via setMwGlobals the ones relevant to the test