[01:56:52] <zabe>	 ConfigException from line 57 of /workspace/src/includes/config/MultiConfig.php: MultiConfig::get: undefined option: 'GlobalBlockingDatabase'
[01:56:53] <zabe>	 bag
[01:56:59] <zabe>	 s/bag/bah
[01:58:09] <TimStarling>	 where is that? in CI?
[01:58:30] <zabe>	 yes
[01:58:31] <zabe>	 https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-selenium-docker/106750/console
[01:58:35] <zabe>	 for https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-selenium-docker/106750/console
[01:58:47] <zabe>	 https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GlobalBlocking/+/769146/
[02:04:10] <TimStarling>	 ok, in new code, it's probably not failing in master
[02:05:22] <zabe>	 no
[02:05:38] <zabe>	 it's not going to fail in master
[02:11:29] <TimStarling>	 are you using that $wgWikimediaJenkinsCI hack when you test locally?
[02:11:38] <TimStarling>	 		if ( isset( $wgWikimediaJenkinsCI ) && $wgWikimediaJenkinsCI ) {
[02:11:38] <TimStarling>	 			$wgGlobalBlockingDatabase = $wgDBname;
[02:11:38] <TimStarling>	 		}
[02:12:11] <TimStarling>	 CI is probably relying on this, it wouldn't have $wgGlobalBlockingDatabase in its LocalSettings.php
[02:22:30] <zabe>	 With 'it works locally' I was referrering to me running update.php by hand and see the schema change correctly being applied. But thanks I am going to try that.
[02:29:49] <zabe>	 it's doing that '$wgGlobalBlockingDatabase = $wgDBname;' in GlobalBlockingHooks::onRegistration, but I guess thats too late here
[02:35:15] <zabe>	 we are so early, not even wgWikimediaJenkinsCI is set :/
[02:37:48] <TimStarling>	 CentralAuth isn't even trying to update shared tables in update.php, it just uses a UnitTestsAfterDatabaseSetup hook to create the tables locally for unit tests
[02:39:58] <TimStarling>	 CentralAuth does also have a $wgWikimediaJenkinsCI hack in LoadExtensionSchemaUpdates, not sure if it is functional
[02:44:49] <zabe>	 removing it has at least no effect on ci (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/769149/)
[02:47:13] <TimStarling>	 you're assuming true there, I'm saying it may even pass if you assume false, i.e. comment out the whole function
[02:52:23] <zabe>	 that actually does not work
[02:54:12] <zabe>	 so wgWikimediaJenkinsCI seems to have an effect there, which implies I am doing something wrong
[03:03:52] <zabe>	 the problem is that wgWikimediaJenkinsCI or MW_PHPUNIT_TEST are only defined when we are actually are running the phpunit tests, the failure here is already showing up in the wiki setup phase