[11:04:56] <duesen>	 Krinkle: done. just a few nitpics about docs
[12:13:01] <Krinkle>	 duesen: thx, done
[12:23:01] <Krinkle>	 Amir1: he, inline profile breaks CSS/JS responses now. https://phabricator.wikimedia.org/P23087
[12:23:12] <Krinkle>	   6.41% 25.266      1 - section.query-m: SELECT /* .. */ ..
[12:23:19] <Krinkle>	 the comment is included and not escaped 
[12:24:10] <Amir1>	 :(((
[12:24:13] <Krinkle>	 How is there literally no escaping in ProfilerOutputText?
[12:24:15] <Amir1>	 Is there a ticket
[12:24:18] <Krinkle>	 not even for the html case
[12:24:33] <Krinkle>	 although granted, I guess it's less likely for the php method syntax to break html
[12:24:38] <Krinkle>	 on the other hand, user input from sql text
[12:24:52] <Krinkle>	 Not yet
[12:25:40] <Krinkle>	 I'll do what ResourceLoader::makeComment does
[12:25:47] <Krinkle>	 Which is lame, but works
[12:31:34] <Amir1>	 !bash Krinkle 
[12:31:34] <stashbot>	 Amir1: Stored quip at https://bash.toolforge.org/quip/WUUPwX8B6FQ6iqKihs2h
[12:31:44] <Amir1>	 Ugh
[12:31:50] <Amir1>	 Stupid phone 
[12:32:16] <Amir1>	 !bash <Krinkle> which is lame but it works 
[12:32:16] <stashbot>	 Amir1: Stored quip at https://bash.toolforge.org/quip/EQUQwX8B8Fs0LHO5KhRo
[12:32:44] <Amir1>	 I'll delete the first one later ;)
[14:50:12] <Krinkle>	 I ran fixDoubleRedirects.php on wikitech to fix 20 or so redirects.
[14:50:20] <Krinkle>	 I'm noticing some.. interesting side effects
[14:50:34] <Krinkle>	 1. The edits aren't in recent changes neither for human nor bots
[14:50:42] <Krinkle>	 2. The user shows as "not registered" - https://wikitech.wikimedia.org/wiki/Special:Contributions/Redirect_fixer
[14:50:57] <Krinkle>	 3. page history lacks a "contribs" link. https://wikitech.wikimedia.org/w/index.php?title=Data_center&action=history
[14:52:00] <Krinkle>	 I'm guessing that whatever we've done for other system users, we forgot to do for this one
[14:53:00] <Krinkle>	 The code certainly doesn't look at all what we normally do
[14:53:02] <Krinkle>	  !self::$user->isRegistered() ) {
[14:53:02] <Krinkle>	 				self::$user->addToDatabase();
[15:04:27] <Krinkle>	 Is there actually a use in having each scirpt use its own user name vs just re-using `MediaWiki default` or `Maintenance script` more often?
[15:13:27] <Krinkle>	 huh, interesting. EDIT_SUPPRESS_RC makes it excluded entirely from RC, not even flood/bot flag
[15:23:53] <Krinkle>	 Ah, I see, it's originally for use via a checkbox on move page, so it'd be a side-effect of something in RC already.
[15:24:02] <Krinkle>	 https://www.mediawiki.org/wiki/Special:Code/MediaWiki/r37928
[17:53:44] <Krinkle>	 Ah and then we have the EDIT_INTERNAL optimisation..
[17:54:37] <Krinkle>	 which seems to have no practical effect on the task it was added for, T136678 
[17:54:37] <stashbot>	 T136678: Investigate how to increase edit stash hit rate - https://phabricator.wikimedia.org/T136678