[18:48:10] Reedy: Hm.. I guess it needs to be one brace pair down, it's the one for the method. [18:48:16] https://doc.wikimedia.org/cover/IPSet/IPSet.php.html#189 [19:56:15] Krinkle: ffs [19:58:19] or maybe both? [20:00:05] This feels dejavu [20:00:47] I filed https://phabricator.wikimedia.org/T307409 to add an exception for codeCoverageIgnore in MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment [20:00:50] * Reedy just reverts [20:02:12] aye, now it complains about Squiz.WhiteSpace.FunctionSpacing.After [20:02:24] I guess an extra line break might work, if there isn't some other thing that violates. [20:02:37] but yeah, the end-of-line version was certainly simpler [20:02:48] it works a bit better if it's not the end of the function [20:03:24] right [20:05:21] would also be nice if `check coverage` worked on libraries [20:05:24] (there's a task for that)