[19:00:11] zabe: anything else you'd like me to review? my gerrit inbox is again rather full, so I might miss patches if you don't ping me here or elsewhere [19:01:52] I would be very happy if at some point https://gerrit.wikimedia.org/r/c/mediawiki/core/+/763788 and then https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/725894 would get in. But I don't expect you to do that. Otherwise I don't really have anything. [19:05:56] a two-line change with two +1's from folks with +2 access looks a bit scary [19:11:58] Yeah. I guess the problem is, that cross-wiki blocking is something no-one really touches and that it something, which still is very broken. [20:51:41] what's the risk? [20:53:44] tbh, there is no real risk. The core patch itself should be a no-op in wmf prod. [20:56:43] The CA patch is a bit more difficult. In generall it can be tested very well, but for global suppressions there is always the problem that there is no multi-shard testing environment (but that only makes problems quite rarely).