[17:31:18] Would be nice to make WikimediaDebug a bit more sticky [18:02:07] Reedy: I'm trying not to get nerd sniped by this :), but can you explain a bit more or make a phab task? https://phabricator.wikimedia.org/project/view/4924/ [18:47:32] bd808: lol [18:47:40] Mostly "stay on till I turn it off" type of thing [19:56:59] Reedy: ah. I shouldn't be too hard to add support for longer/indefinite sessions. If I remember right making it time out was a feature that we added purposefully because other folks were surprised when it stayed on. :) [19:57:03] Reedy: it goes off after 15min to avoid staying on an mwdebug all day, esp for those using it to stage deployments or verify it. e.g. volunteer requesting config change. [19:57:23] as well because people might then ad-hoc debug and put other things there while you're still on it [19:57:45] yeah, that's a potential danger of always on for sure [19:58:27] the icon shows "ON" in the toolbar which makes it visible at least [19:58:50] * bd808 should be careful about seeming to be an active maintainer of the addon [19:58:57] hehe [19:59:59] It's super cool and I was happy to be involved with the Firefox port, but if o.ri and I had used the same browser at the time I never would have touched it. :) [20:00:17] !bash * bd808 should be careful about seeming to be an active maintainer of the addon [20:00:18] taavi: Stored quip at https://bash.toolforge.org/quip/SESkk4IB6FQ6iqKip7zH [20:03:42] Krinkle: Even if it's not the default mode... [20:03:53] But for example, testing PHP 7.4, I'd like it to just stay on that :) [20:04:33] Makes it easier to do normal usage patterns [20:05:01] Reedy: ack, but that's not that mwdebug is for. We have a cookie for PHP_ENGINE afaik, or is being created at least [20:05:12] which wil work on all appservers [20:05:44] https://gerrit.wikimedia.org/r/818481 [20:06:36] as-writen this will "correct" manual cookies to fit the sampled polutation, so will likely undo cookies [20:06:57] maybe _joe_ would accept an exception of sorts. [20:07:51] e.g. condition the removeCookie path to no-op if PHP_ENGINE_OPTIN=1 exists [20:07:58] then you can just run it once and it'll stay [20:09:19] <_joe_> ah sure [20:09:27] <_joe_> or you can regenerate your seed :D [20:25:53] I expected that someone would write a global.js snippet that'll set the PHP_ENGINE cookie [20:26:25] that would race with wmE removing it for the non-sampled group [20:27:07] PHP_ENGINE_REAL [20:27:29] :) [20:28:04] mw.config.set( 'WMENewPHPSamplingRate', 100 ) won't work right? also racey? [20:29:00] it's not mw.config anymore these days reduce page/startup payload, we generally bundle a virtual .json file now [20:29:07] and thus not creating implicit global APIs [20:29:09] right right [20:32:53] there you go: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaEvents/+/822682/ [20:34:17] you're awesome [21:01:09] <_joe_> <3