[18:07:36] <Amir1>	 does anyone know why phan is failing for REL1_39? https://integration.wikimedia.org/ci/job/mediawiki-core-php74-phan-docker/12/console
[18:07:47] <Amir1>	 did we forget to backport a patch?
[18:08:20] <zabe_>	 https://gerrit.wikimedia.org/r/c/mediawiki/core/+/829876 needs to go in
[18:08:41] <zabe_>	 php 7.4 phan is non-voting on master
[18:08:45] <Reedy>	 heh
[18:08:51] <Reedy>	 jerkins says no
[18:09:24] <Reedy>	 I see other PHP 8.1 fails
[18:09:25] <Reedy>	 02:41:48 strtr(): Passing null to parameter #1 ($string) of type string is deprecated
[18:09:59] <Reedy>	 8 of them
[18:12:57] <zabe_>	 is it possible to suppress a phan issue for only one php version?
[18:14:37] <Reedy>	 in theory you can do an if ( PHP_VERSION > something ) { /* suppress */ }
[18:15:13] <Reedy>	 all 8 errors are the same line in BagOStuff
[18:15:53] <Reedy>	 https://github.com/wikimedia/mediawiki/commit/2ded6a222db3dab04ee5cc661d2e6383e4595f32
[18:15:54] <Reedy>	 lol
[18:15:58] <Reedy>	 so the fix was only recently reverted...
[18:16:16] <Reedy>	 Well, a fix, that wasn't a complete fix
[18:16:17] <Reedy>	 https://github.com/wikimedia/mediawiki/commit/453d7c58390b6b878f861c9c5d592c749d69347d
[18:17:24] <Reedy>	 https://phabricator.wikimedia.org/T317149
[18:19:01] <Amir1>	 first rule of mediawiki, don't look at anything too closely 
[18:19:38] <Reedy>	 $component ?? '' or is_string( $component ) {} wrapping it
[18:20:11] <Reedy>	 of course, no point appending null either
[18:21:59] <Reedy>	 really, we should stop passing in null
[19:13:28] <Krinkle>	 (I agree.)
[19:13:59] <Krinkle>	 But for REL we could just put the bandaid back on
[19:14:28] <Krinkle>	 1.39 was only just cut though, doesn't this affect master?
[19:18:06] <Reedy>	 Yes, but no because 8.1 isn't voting on master
[19:18:36] <Krinkle>	 Ah, right
[19:18:56] <Reedy>	 So yeah, we need a fix on master (eventually) too... But only release branches is this a problem (for now)
[19:19:13] <Krinkle>	 Well I suppose we can put it back on and then within master keep it off like now and backport any actual bug fixes to REL
[19:20:27] <Reedy>	 Yeah... Just need to remember to keep tasks open to track when they still need sorting on master
[19:22:25] <Krinkle>	 Yeah if we fix them "for" 39 first you mean? I was thinking we could revert my revert for 39 only and thus silence this to keep the old behaviour there
[19:23:48] <Krinkle>	 Then on master as we make progress on fixing remaining 8.1 warnings properly we can backport fixes as usual if they are actual bug fixes
[19:24:57] <Krinkle>	 I didn't see any Bago-related warnings in php81 output last I checked. Will check back later. Hopefully just a few, perhaps due to unit test mocks?
[19:26:28] <Reedy>	 It's often so hard to run a full complement of tests locally