[14:29:26] I'm confused why phan is not very cooperative here https://gerrit.wikimedia.org/r/c/mediawiki/core/+/849554 [14:29:43] how can I tell phan the type of a global variable [14:31:31] i'm about 80% sure they are hardcoded somewhere in our config. i can probably find it [14:31:55] I grepped Request in .phan, nothing came up [14:32:31] Amir1: https://github.com/wikimedia/mediawiki-phan-config/blob/ef8c6b086e2c9399125bd18cdde08ccde6ad76ee/src/config.php#L194 [14:33:10] oh another repo. Fun [14:33:39] yeahhh. i think that's so that we can reuse it in extensions [14:35:55] there is also a globals_type_map in .phan/config.php, which duplicates some of the above? maybe you can override it there [14:36:43] yeah, I'm overriding it now [14:37:21] for extensions, we can stick to the non-override because reading aliases is disabled only in core https://gerrit.wikimedia.org/g/mediawiki/core/+/d2499f8ffb9fd95720efefc0831d3ea89bb3dd16/.phan/config.php#109 [14:38:17] oh, nice. i thought this was some limitation, not a config [14:41:26] MatmaRex: phan passing now \o/ [14:41:40] do you like to review/merge the patch? mwhahahaha [14:43:55] mmmaybe? i like to give people a few days to bikeshed about names [14:44:17] The names are approved as part of the RFC [14:44:38] :o