[07:16:00] <Krinkle>	 duesen: TimStarling: FYI - CI is failing due to wgHooks on various repos https://phabricator.wikimedia.org/T331602
[07:18:38] <TimStarling>	 that's expected, as long as it's not breaking on any production repos
[07:19:44] <TimStarling>	 Daniel explicitly wanted to break the universe with this change
[07:20:15] <Krinkle>	 CentralAuth and MathSearch are production
[07:21:11] <Krinkle>	 anyway, we have until Monday after that we'll probably revert the hard-deprecate if it floods prod and/or still breaks CI by then.
[07:21:14] * Krinkle goes to bed
[08:36:22] <TimStarling>	 I don't see MathSearch in production, but if it breaks CentralAuth it can be reverted
[10:21:50] <Lucas_WMDE>	 was this intentional universal breakage announced anywhere? I don’t see anything on wikitech-l at least
[10:49:39] <duesen>	 Is anything other then CentralAuth failing? It's the only thing I'm aware of so far.
[10:50:11] <duesen>	 Lucas_WMDE: it's just a hard deprecation like any other... I can send an email about it, but it's not really special.
[10:50:58] <Lucas_WMDE>	 Tim’s comment sounded to me like you were expecting breakages in tons of extensions
[10:51:07] <Lucas_WMDE>	 so I was wondering how those extensions were supposed to find out what they needed to change
[10:51:12] <Lucas_WMDE>	 maybe I misunderstood ^^
[10:51:25] <duesen>	 There are some third party extensions that will start emitting deprecation warnings. Which breaks tests.
[10:51:33] <duesen>	 I filed tickets for the ones that I know about. 
[10:52:02] <duesen>	 I tried to fix everything we have in prod (obviously, I missed CentralAuth)
[10:52:15] <Lucas_WMDE>	 ok
[10:52:22] <duesen>	 I'll have another look at MathSearch
[10:56:54] <duesen>	 So the MathSearch test fails also because of CentralAuth it seems, https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MathSearch/+/902490/1#message-4aa53c4e198d6292e98deaaaf48891162ed7da4e
[10:58:08] <duesen>	 Lucas_WMDE: want to review the fix?https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/904453
[10:58:19] * Lucas_WMDE looks
[10:58:37] <duesen>	 it's simple enough, but properly testing it is hard.
[10:58:43] <Lucas_WMDE>	 that one was already +2ed 45 minutes ago though?
[10:59:06] <duesen>	 oh heh, good then :)
[10:59:10] <Lucas_WMDE>	 ok, the fix looks straightforward enough indeed
[11:00:09] <duesen>	 One thing that is a bit confusing about it is that it's still ok to use $wgHooks in "extension callbacks" but it's not ok in "extension functions".
[11:00:38] <duesen>	 "callbacks" run before bootstrapping MediaWikiServices, "functions" run after. The naming is terrible.
[11:30:18] <Soustruh>	 Hello everyone, could I please ask someone to perform a triage on this task? https://phabricator.wikimedia.org/T329610 😇