[16:48:17] <xSavitar>	 Krinkle, while reading through SiteConfiguration.php, I see a public method called `extractVar()` which seems unused. I've tried to track when it got introduced but to no avail. Looks like it should be deprecated and removed? Seems like dead code to me.
[16:48:20] <xSavitar>	 What do you think?
[17:01:37] <xSavitar>	 There is also extractGlobal() too
[17:41:44] <xSavitar>	 Proposed a patch :) - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/926671
[18:04:05] <Krinkle>	 xSavitar: interesting. Can you spot check a few points in recent years from the commit history of that file e.g. 2 years ago and 5 years ago, whether it was used then? That'll help understand whether it is likely a mistake, or whether it is likely to be needed again soon, or whether it is used in a special way that we might not see. 
[18:04:36] <Krinkle>	 You can use git log -- includes/Foo for that, or git blame in Gerrit/Gitiles or elsewhere