[08:14:20] Krinkle, I already did some finding yesterday going backward when this method was introduced but can't find a linking patch on Gerrit. But I'll still dig again today because I want to use that as an explanation in the commit message of the proposed patch. [08:22:19] Oh, on the GitHub UI, I see it was introduced 19 yrs ago here: https://github.com/wikimedia/mediawiki/commit/5cec39714b040f70e2fa0acb2558f8a694ff3717 [08:27:22] invoking TimStarling as he authored the code, I think they have the best explanation on what to do moving forward. [11:17:50] xSavitar: https://www.mediawiki.org/wiki/Gerrit/Advanced_usage#Code_Review_links [11:18:10] After doing that (only one time is needed per laptop), you can get this locallyu: [11:18:19] `$ git show 5cec39714b040f70e2fa0acb2558f8a694ff3717 [11:18:19] http://mediawiki.org/wiki/Special:Code/MediaWiki/3670 [11:18:19] ` [11:18:39] That's where the code review is for pre-Gerrit :) [11:18:58] although this one does not have code review comments, so no extra info this time [11:35:48] xSavitar: So the intro patch indeed doesn't use it, but it doesn't use anything else from the class either. SiteConfiguration is mainly invoked and called from LocalSettings.php, so it's hard to know how it's really "used". [11:35:59] In our case, we call it from wmf-config in operations/mediawiki-config [11:36:15] in any case, I think it's okay to deprecate and remove. [13:02:28] Special:Code started in 2008 [15:19:36] TimStarling: ack, but we did sometimes comment on old revs or link to them from later commits. e.g. 2007 commit https://static-codereview.wikimedia.org/MediaWiki/21833.html has follow-up mentions from 2008. But yeah, pretty rare. I didn't know it was 2004 until after opening the Special:Code url. [23:03:28] I don't think it was used, but it is a logical extension to extractGlobal. It hints at a desire for non-global config variables [23:04:44] I sometimes added unused code for completeness or to hint at some future direction, sometimes still do to be honest [23:04:59] like half the code in WRStats