[12:21:35] Lucas_WMDE: If you don't mind, I have a question regarding T334682 that I can't shake. The smaller version is awesome, but I wonder.. how did this work in legacy Vector? It seemed from the original report that this module was loaded on V22 but not in legacy Vector, but ULS seemed to work either way. It seems like maybe there is a missing piece of information around why the module is loaded so early and/or at all. Does that make sense? [12:21:36] T334682: [WBClient] Mitigate size of included resource module `mw.config.values.wbSiteDetails` in Wikibase Client sites - https://phabricator.wikimedia.org/T334682 [12:30:43] Krinkle: the legacy vector version of the module doesn’t link to the specific sitelinks section [12:30:51] the new one links to e.g. Q42#sitelinks-wikipedia [12:31:01] and the “wikipedia” site group is the information we get from the RL module [12:31:42] https://en.wikipedia.org/wiki/K-pop?useskin=vector -> "Edit links -> https://www.wikidata.org/wiki/Special:EntityPage/Q213665#sitelinks-wikipedia [12:32:50] hm [12:33:00] clicking that in legacy vecotr, performs a navigation, no JS involved and that's how I remember indeed, no JS [12:33:01] then I’m not sure where the old module gets that from [12:33:05] in modern vector, clicking it seems to do nothing [12:33:13] broken JS? [12:33:49] https://en.wikipedia.org/wiki/K-pop?useskin=vector-2022&safemode=on [12:33:55] that’s probably T337081 [12:33:56] T337081: "Add interlanguage link" shows a bubble: "An unknown error occurred" - https://phabricator.wikimedia.org/T337081 [12:34:06] it's server-rendered HTML: ="wb-langlinks-edit wb-langlinks-link"> (doesn’t show a bubble anymore but still not quite fixed) [12:34:24] ah, and in vector-2022 it’s client-rendered I guess [12:34:38] the link exists in html both ways. [12:34:51] I do recall seeing a jquery UI modal at some point, but it's been years since I saw that show up on click. [12:34:56] I assumed it was removed [12:35:13] I think it’s still there but only under certain circumstances (I forget which) [12:35:19] ah okay [12:35:34] something like, there’s a connected item but it has no other sitelinks, or something like that idk [12:37:55] Lucas_WMDE: so there's a recent regression I guess that now fully breaks the wikidata language links edit link in V22. [12:38:10] and re “the link exists in html both ways”, I believe we’re supposed to remove the one under Tools from vector-2022 eventually? the JS-added link is in the ULS popup, under Add languages [12:40:05] brief debugging shows there's a click handling doing some event emulation in a way that probably doesn't work. [12:40:21] anyway, file a task if it seems like either wikibase client or vector has a bug. [12:40:36] thx for clarying the wbSiteDetails aspect of it [23:08:06] TimStarling: do you recall the steps you used to add luasandbox docs to php.net? I'm trying to add excimer as well. I got something half working locally, but not sure what the right approach is. I [23:09:20] I'm guessing ultimately it's down to a pull request to the upstream "doc-en" repo, but I'm wondering how much if any can be auto-generated if I first change excimer itself. [23:13:09] I think Brad did the boilerplate for luasandbox and committed the result to gerrit, then I copied it to doc-en [23:15:14] there is a stub generator script somewhere, but I haven't used it [23:17:45] the documentation just says to use the skeleton files from doc-base/RFC/skeletons, although I was told on a previous PR that the editor folding in function.xml is outdated and should be removed [23:18:12] that is the comments like [23:19:33] oh ok, the stub generator is doc-base/scripts/docgen/docgen.php [23:19:56] it is the first FAQ at http://doc.php.net/tutorial/faq.php