[04:53:47] xSavitar: Have you done a php library release before? If not, perhaps T327992 would be interesting. We can pair on it this week if you like. [04:53:49] T327992: Publish wikimedia/cdb v2.1 release - https://phabricator.wikimedia.org/T327992 [11:42:30] Krinkle, not I've not but happy to pick it as a side project and pair with you :) [15:18:06] Krinkle, read some docs and made some patches. Will add you once it's passing CI :) [16:30:54] xSavitar: cool. btw, did you create the 2.1.0 tag or was that already there? [16:53:16] Krinkle, it was already there. Looks like James F created it a while ago. [16:53:46] Hm.. I ask because it is missing CHANGELOG.md entry, and seems to be a breaking change (PHP requirement change) which we usually tag semver on. [16:54:02] If the tag is not signed, then github usually shows the author as the commit, so might not have been James_F [16:54:13] also, it seems the tag does not exist in gerrit, which is extra odd [16:54:17] https://gerrit.wikimedia.org/g/cdb/ [16:54:20] last tag there is 2.0.0 [16:54:35] semver-major* [16:55:14] Krinkle, https://github.com/wikimedia/cdb/releases/tag/2.1.0 [16:55:56] Yes, it's not in Gerrit, I looked there and didn't see it but something told me to look at GH also :) [16:58:27] xSavitar: OK, I suggest writing a patch that adds 3.0.0 to the changelog, then once merged, push a 3.0.0 tag, and then use that. I'll import the 2.1.0 tag to match the github commit for now, but I wouldn't use it. [16:58:41] gh is a mirror, so there should not be data there that isn't the source. [16:58:55] it's very possible that I was testing something a few months ago and forgot about it. [16:59:36] Okay! [17:14:28] Krinkle, there's no diff between 2.1.0 and master [17:14:41] So it seems nothing will be in the changelog [17:14:51] xSavitar: from 2.0.0 to 3.0.0, we ignore 2.1.0 :) [17:14:59] there is no 2.1 changelog entry [17:15:03] it was never properly released [17:15:13] and given the breaking change, it should be in 3.0 [17:15:17] Okay, makes sense. I'll do that [18:06:18] Ah, not sure if I pushed that tag for cdb or not. [18:06:21] Sorry if so. [18:13:44] Krinkle, added you as reviewer for the changelog patch. Cc James_F :) [18:14:27] Just in case, I used https://github.com/git-chglog/git-chglog to make my life easier :D [18:28:10] I typically use something like `git log --format='* %s (%aN)' --no-merges --reverse $(git describe --tags --abbrev=0 HEAD)...HEAD` [18:28:25] which I guess does something very similar [18:36:24] Okay nice! That's a very geeky way of doing stuff. Too big for my tiny little brain :D [18:36:30] Krinkle, I've pushed the new tag: https://gerrit.wikimedia.org/r/admin/repos/cdb,tags [18:36:38] I'll go ahead and update patches now. [18:51:17] In case anyone is wondering about random patches I'm doing past weekend and today - I'm setting up a new laptop and going through local branches and `git stash` lists I had laying around and seeing what can be salvaged (going for a clean install, moving only critical data, not repos). [18:51:55] made easy by `do-globalgitstatus` https://github.com/Krinkle/dotfiles/blob/6fa0d688d1da4f4bffb7d228ba10c7249683b07d/hosts/primary/index.bash#L270