[10:05:45] <lgaulia>	 Howdy!  What is the "new HookContainer/HookRunner system"? context: Update CentralAuth to use the new HookContainer/HookRunner system (T270846)
[10:05:46] <stashbot>	 T270846: Update CentralAuth to use the new HookContainer/HookRunner system - https://phabricator.wikimedia.org/T270846
[10:38:55] <taavi>	 lgaulia: it's the "new" (as of mediawiki 1.35) system to run hooks that supports dependency injection etc. https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/refs/heads/master/docs/Hooks.md
[11:02:57] * lgaulia reads
[20:06:44] <Reedy>	 trivial +2 if anyone is bored :) https://gerrit.wikimedia.org/r/c/HtmlFormatter/+/951493
[20:17:22] <Reedy>	 cheers zabe
[20:18:17] <zabe>	 yw
[20:18:37] <Reedy>	 can hopefully fixup and push that stack of outstanding changes through...
[20:20:55] <MatmaRex>	 i was looking as well, but i don't understand why ReturnTypeWillChange is needed there
[20:24:13] <MatmaRex>	 oh, i think i get it. because you added a return type hint in HtmlFormatter, and we have existing code elsewhere that subclasses it without that type hint, causing warnings on PHP 8.whatever
[20:25:15] <Reedy>	 Yeah
[20:25:26] <Reedy>	 We could just force CI through, but when there's ways around...
[20:32:30] <Reedy>	 Hmm. Or not, apparently
[20:33:38] <Reedy>	 oh fffs
[20:33:44] <Reedy>	 I added it to the wrong bloody function
[20:34:30] <Krinkle>	 $i++;
[20:36:28] <Reedy>	 21:31:56 Fatal error: Declaration of MobileFormatter::parseItemsToRemove() must be compatible with HtmlFormatter\HtmlFormatter::parseItemsToRemove(): array in /workspace/src/extensions/MobileFrontend/includes/MobileFormatter.php on line 69
[20:36:31] <Reedy>	 https://gerrit.wikimedia.org/r/c/HtmlFormatter/+/951494
[20:41:42] <Krinkle>	 https://gerrit.wikimedia.org/g/mediawiki/extensions/TextExtracts/+/71e31619f2a3c3fcaca6c714094b271ac5e4622c/includes/ExtractFormatter.php#82
[20:41:52] <Krinkle>	 Do we need both? Reedy
[20:42:18] <Reedy>	 both what?
[20:42:33] <Reedy>	 That should be updated too... But I'm guessing it's not gated, so didn't show up for James
[20:42:36] <Krinkle>	 Attribute will change on both
[20:42:40] <Reedy>	 oh
[20:42:41] <Krinkle>	 Right
[20:42:48] <Reedy>	 Yeah, good point though
[20:42:56] <Reedy>	 Ok, so 4.0.1 wasn't completely useless
[20:43:22] <Krinkle>	 I guess if not gated you could update afterward.
[20:43:52] <Reedy>	 not like the comment harms anything either
[20:47:41] <Reedy>	 onHtmlReady is another
[20:48:12] <Reedy>	 And getText
[20:55:27] <Reedy>	 patch for textextracts up now... and all the relevant functions attributed too