[12:08:41] Krinkle: it would be amazing if you could check our comments here https://phabricator.wikimedia.org/T344926#9130358 [14:53:44] James_F, hi there! I was slowing eyeing https://phabricator.wikimedia.org/T303227 but I see that the latest release is already being used by core. Is there anything to do there? [14:57:41] xSavitar: Oops, yes, done last year. [14:58:04] Okay, I'll resolve it. [14:58:26] Never mind, you beat me :D [14:59:42] Actually, I'll go through that list and update it to make sure what is left is what needs to be done. [15:23:25] pmiazga: sounds good to me. Beyond short-term it makes sense for ObjectCache::newFromParams to inject the http client indeed if class==RESTBagOStuff, similar to other services we inject via there. That could be MultiHttpClient, or some PSR interface. Note that wikimedia/objectcache is a library, so it can't use HttpRequestFactory, but if used agnostically through PSR it could work. Otherwise, injecting [15:23:25] HttpRequestFactory->getMultiHttpClient may suffice [19:37:41] if anyone could review https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/953715 , i'd like to backport it today [19:41:31] duesen: Was chatting with Moriel about an issue and she suggested you might have some thoughts about how to procede. Filed as T345289 as a very rough sketch. [19:41:32] T345289: Come up with a way to make Wikifunctions calls not keep a PHP process alive whilst waiting for the backend - https://phabricator.wikimedia.org/T345289 [20:21:12] James_F: i replied there+ [21:15:56] duesen: did it work our regarding stampede protection? Ref https://gerrit.wikimedia.org/r/c/mediawiki/core/+/935716 [21:15:59] work out* [21:59:48] Krinkle: Any chance you could log in to packagist and purge https://packagist.org/packages/mediawiki/phan-taint-check-plugin so it spots v5.0.0 that we just pushed? [22:00:09] * James_F is a lowly no-rights peon. :-) [22:00:45] James_F: done [22:00:49] Thanks! [22:00:52] I guess the webhook needs to be fixed? [22:01:08] I think sometimes it just doesn't work but sometimes does? [22:01:38] There's a note on one of the "move to GitLab" tasks to switch packagist updates to pull from our GitLab and not GitHub, IIRC. [22:07:49] * Krinkle adds org-wide webhook to https://github.com/organizations/wikimedia/settings/hooks