[17:21:11] > // For now, shunt the revision data into the archive table. [17:21:11] That "for now" is at least fifteen years old [17:21:34] (hopefully not for long, after pagelinks normalization) [17:21:52] Amir1: You don't love our temporary solutions? [17:22:49] I love them so much I think about them every day! [17:45:39] There are now only around 80 migrations left to do to SelectQueryBuilder in core, I cataloged them https://phabricator.wikimedia.org/T344971 some are pretty easy to do [18:01:46] Amir1: Some are already done/your list is out of date [18:02:03] recompressTracked being one [18:02:25] They have some that are not done yet [18:02:28] partial migration [18:02:38] e.g. that one: $dbr->selectField( 'blob_tracking', [18:02:46] duh [18:02:53] I was looking for ->select( [18:02:58] :D [18:03:33] That's why my grep had issues, I looked for select* and db->selectDomain is a valid function [18:05:02] Also https://gerrit.wikimedia.org/r/961073 is not merged yet but I assumed it's merged in the ticket [18:05:15] * Reedy does a few other ones [18:05:33] Thanks <3 [18:06:25] What do we do with selectSQLText? [18:06:49] oh [18:06:50] getSQL [18:06:51] easy [18:07:12] yup, sorry I was afk [20:05:30] Amir1: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/961226/2/includes/specials/SpecialPrefixIndex.php [20:08:15] thanks [20:08:36] I had a quick look, but didn't see any examples actually doing it [20:08:42] Probably because no one has "done this" since [20:09:56] yeah [20:10:09] In general, I'm not a big fan of hooks [20:10:22] but we don't have an alternative yet [20:10:25] indeed [20:41:24] yay, rabbit holes [23:24:28] Krinkle: re: bounce tracking mitigation (sorry, since Matrix got disconnected, I don't check IRC pings much), yes it would probably break the rest of central login (both the new top-level thing and Special:CentralLogin). But it's not used anywhere except maybe Safari. [23:25:17] It's used in Chrome when 3PC blocking is enabled but 3PC blocking needs manual opt-in until middle of next year. [23:27:26] ack yeah, the prompt was Google adopting it, and it seems like our change which was meant to fix Safari/Firefox *and* prepare us for Google's upcoming third-party cookie block, seems like it might not, at least not as-is. [23:28:23] 10% of Chrome stable as of yesterday (for those that opt-in). https://groups.google.com/a/chromium.org/g/blink-dev/c/Lxi7LfRyI4c/m/xeKepQFOAQAJ