[11:31:29] <_joe_> do we have a condoned way to do geoip lookups in MediaWiki? [11:31:58] <_joe_> context is https://phabricator.wikimedia.org/T352156#9363024 [11:33:19] <_joe_> i know we now import geoip2/geoip2 [11:56:18] I see Kosta just uploaded a WIP patch [11:57:15] personally I'd avoid the extension dependency by just using the library directly [11:58:12] a bit of a nuisance to duplicate the configuration of the database path but that's better than requiring a large extension with UI functionality just to get a wrapper class [12:26:14] <_joe_> tbh I think a geoip library should be in core [12:26:34] <_joe_> like, it seems like something any extension developer might want to use [12:26:43] <_joe_> I get the problem is it's vendor-specific [12:26:46] <_joe_> sigh [12:28:23] It's trivial to add a "duplicate" entry in composer.json in an extension [15:01:15] Adding to to core would be the same as adding to each extension directly, it still requires each consumer to have knowledge of files/config to work [15:01:33] Unless we also add that to core too [15:06:34] <_joe_> that would be the idea, right? we have a single key to indicate the prefix of where the mmdb files are located [15:06:41] <_joe_> a single config key [16:13:09] If MW core presented it as a service, yeah [16:13:21] rather than just having a random composer.json entry that means the code is at least present [16:24:30] _joe_'s comments sounds a lot like T174553 [16:24:31] T174553: Create a mechanism that allows fetching geolocation and subnet data for IP addresses - https://phabricator.wikimedia.org/T174553 [16:25:37] * bd808 has feelings about MaxMind as a specific vendor that carry over from $DAYJOB-1 [18:46:33] Krinkle: Phab lacks an emote feature for individual comments, so thank you very much for your well explained take at https://phabricator.wikimedia.org/T169027#9362252. That cannot have been quick or simple to write, and I think it is a helpful perspective. [18:47:01] thx <3 [18:48:41] Not pulling the extension when it was leaked into production by former staff was a confusing outcome for everyone