[00:00:05] <Amir1>	 Full query can be quite needed in many cases
[00:01:50] <Amir1>	 Anything after 2k is very likely useless anyway
[00:02:18] <Krinkle>	 Amir1: k, patching. I guess we'll want mb_substr to avoid invalid UTF-8 in JSON.
[00:02:48] <Amir1>	 Sounds good
[11:25:24] <_joe_>	 hi, I'd need mediawiki dev help for https://phabricator.wikimedia.org/T352515
[11:26:01] <_joe_>	 basically, we would need to re-introduce https://gerrit.wikimedia.org/r/c/mediawiki/core/+/720143 or djvu uploads are broken on k8s
[11:26:42] <_joe_>	 SRE is trying to put in a mitigation - basically sending Special:Upload to bare metal - but I'd love some help in fixing the issue with shellbox
[11:48:11] <Lucas_WMDE>	 if I’m writing an integration test that has to change two services, should I use overrideMwServices() or call setService() twice?
[11:48:35] <Lucas_WMDE>	 the method docs say that both are mutually incompatible but don’t really explain why to choose one or the other imho
[11:48:55] * Lucas_WMDE (can’t help with T352515, sorry)
[14:18:45] <Krinkle>	 Lucas_WMDE: setService, unless you're testing something with DI and a custom service container object
[14:37:24] <Lucas_WMDE>	 alright, thanks!
[16:40:38] <_joe_>	 why is a lint check from MediaWiki thinking he knows how clean code is written better than me?
[16:41:18] <_joe_>	 and, how do I disable the 'duplicated lines density' check when I know what I am doing?
[16:41:43] <_joe_>	 I hate linters that get in the way of writing efficient code in name of some vague concept of cleanliness
[17:03:21] <Lucas_WMDE>	 _joe_: if you’re referring to https://gerrit.wikimedia.org/r/c/mediawiki/core/+/979386, you can just ignore SonarQube Bot imho
[17:03:35] <Lucas_WMDE>	 the errors in the composertest and phan builds are more important
[17:06:06] <_joe_>	 yes ofc
[17:07:51] <_joe_>	 one of the phan warnings is about preexisting code, which is hilarious 
[17:08:02] <_joe_>	 the others are just me forgetting scoping rules in php 
[17:09:49] <Lucas_WMDE>	 at the risk of saying more obvious things – for the line length I’d extract a $services variable to replace that MediaWikiServices::getInstance() copy+pasted everywhere
[17:10:01] <Lucas_WMDE>	 (but “ignore sonarqube” is probably the most useful advice I have here ^^)
[17:26:10] <tgr>	 _joe_: do you still need help?
[17:50:09] <_joe_>	 tgr: well I wrote a first version of a patch, but I will probably need help figuring out what's wrong on CLI
[21:53:19] <tgr>	 _joe_: it doesn't seem like we actually use shellbox for file uploads much? both PDF and TIFF are disabled for Commons: https://codesearch.wmcloud.org/search/?q=wmgUsePdfHandlerShellbox%7CwmgUsePagedTiffHandlerShellbox&files=&excludeFiles=&repos=
[21:54:20] <tgr>	 and presumably djvu would have to be for the same reason (file size limits). So this won't necessarily help as a workaround for unshellboxed djvu processing causing issues, unless those issues really are limited to wikisource