[21:24:45] Amir1: why does acquireLinkTargetId() require a database handle to be passed in, while getLinkTargetId() doesn't? [23:00:03] TimStarling: heh, I spent so long making a comment saying "I think that's OK" that I saw you already merged the patch ;) [23:00:53] merge conflict on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/982777/2 btw [23:10:18] we don't need show tables [23:10:49] when this code was written, we still supported MySQL 4 which lacked INFORMATION_SCHEMA [23:13:11] responding to your second dot point [23:13:48] the merge conflict is just because you changed lines I'm deleting, I'm just running phpunit locally before I upload a new PS [23:32:19] now I'm getting rid of all the SHOW queries