[13:25:14] MatmaRex: could use a second opinion on something. I'm looking at https://codesearch.wmcloud.org/search/?q=%3EgetPageViewLanguage&files=&excludeFiles=&repos= and finding all the calls from skin code, which make sense historically since that predates the relatively new ParserOutput->getLanguage. Noting that the page title, like the page content (and thus DISPLAYTITLE:) are in the page content language, possibly converted to a variant for [13:25:14] the current user's variant preference. Suspiciously absent, however are Vector, Minerva, Monobook, and Timeless. It appears they got their firstHeading lang/dir attribs changed from pageLanguage to `html-user-language-attributes` in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/657450 [13:25:35] That seems wrong to me, but given it's been 2 years, and its consistent in WMF-deployed skins, I wonder if maybe I'm missing something? [13:43:38] Krinkle: hmm, it does seem like a mistake, i guess the difference doesn't come up often in practice. i can't find any bug reports about it either, so it seems no one noticed [13:44:57] Krinkle: but i did find a task about the indicators block also missing these attributes: https://phabricator.wikimedia.org/T344240 the page title should probably use the same ones [13:45:09] (but the patch there looks wrong, it uses the site content language, not page content language) [13:45:53] Ref T36514 [13:45:54] T36514: The language and the direction of the title in first heading should depend on page content language instead of user interface language - https://phabricator.wikimedia.org/T36514 [13:46:32] ooh [13:46:56] For special pages, it is user language but any content language abstraction naturally handles that correctly for NS special [13:47:07] For non-view actions, it's interesting... [13:47:19] Ie "page history of Foo" [13:47:44] yeah. maybe the real answer to why no one cared is that it was broken either way [13:47:50] But for simple page views, it's wrong by default if you're viewing as a user with a non-content language, ie any non-English user on English wiki [13:48:12] That's the majority case and would affect machine translation I imagine [13:48:55] And of course any other semantic or assistive tech reading things variable by language, word lookup etc [13:49:44] I guess where it matters most is dir= [13:50:58] https://en.wikipedia.org/wiki/Nihon_(disambiguation)?uselang=he looks bad indeed [13:51:08] Rendering English title in RTL [13:51:59] The real question is: what do we recommend to all these skins? [13:52:42] Invest in a way to obtain parser language to replace the soon deprecated pageview language, or have them all do the same as vector [14:00:25] yeah. i'm not sure [14:01:07] i wonder if OutputPage::getContentLangForJS() should become a public method, to support this use case. that would probably be the simplest way to do this correctly in those skins [14:03:28] alternatively, maybe make the whole thing function like you've done with the page content, and bake in the language markup into the page title HTML, and then advise skins to do what Vector does and omit the attribute. it's already treated like HTML and has markup inside of it [14:34:28] MatmaRex: hmm you mean for page action=view specifically, where h1 is just the parser output display title, include the attributes there, and when anything else sets it, assume it's user language [14:35:35] Could probably strip those attributes from h1 entirely in that case since anything in the skin is already inherited as user lang outside content wrapper [14:35:54] yeah. and if anything else needs anything else, it can include the right attributes itself [14:35:55] ie no different from sidebar or footer in that regard [14:36:12] The vector patch didn't really make sense either way. [14:36:22] Since we already set that on the html/body [14:36:57] Alright, well, that's a separate task. For now I'll recommend skins get rid of it without replacement. [14:37:27] the patch on T36514 actually tried to do something like that, but it needs a lot of updates (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/419405) [14:37:32] T36514: The language and the direction of the title in first heading should depend on page content language instead of user interface language - https://phabricator.wikimedia.org/T36514 [15:47:29] Looking at x2 stats, I was expecting a nice drop given the work xSavitar has done to move captchas away from mainstash db (x2) to memcached. But instead, something seems to be slamming it at 4K/s, not sure what it is. https://grafana.wikimedia.org/d/000000278/mysql-aggregated?orgId=1&var-site=eqiad&var-group=core&var-shard=x2&var-role=master&from=now-90d&to=now [15:47:52] not seeing anything obvious at [15:47:52] https://grafana-rw.wikimedia.org/explore?orgId=1&left=%7B%22datasource%22:%22000000001%22,%22queries%22:%5B%7B%22refId%22:%22A%22,%22datasource%22:%7B%22type%22:%22graphite%22,%22uid%22:%22000000001%22%7D,%22target%22:%22exclude%28sortByMaxima%28aliasByNode%28MediaWiki.objectcache.%2A.get_hit_rate.rate,%202%29%29,%20%27pcache%27%29%22,%22textEditor%22:true%7D%5D,%22range%22:%7B%22from%22:%22now-30d%22,%22to%22:%22now%22%7D%7D