[11:40:45] duesen: FYI, I just had to bash “MediaWiki itself be deprecated” when I saw it on gerrit https://bash.toolforge.org/quip/6G_f6IwBhuQtenzvHfXO [11:40:51] feel free to delete it if you don’t like it ^^ [12:16:13] https://engineering.fb.com/2023/12/19/core-infra/how-meta-built-the-infrastructure-for-threads/ TLDR: MySQL, a jobqueue, and something (to me, new) called ZippyDB which appears to be a key value store that can semi-automaticity scale over several days. [16:40:23] Where should the "help" of an item on an auth form actually show? [16:52:22] I think it's actually a bug... https://phabricator.wikimedia.org/T354539 [16:56:26] tgr: ^^ [16:56:41] Unless I'm missing something, they don't show on the login form either... [17:04:41] Which as it stands, means a lot of messages being translated, but apparenlty unused [18:06:21] tgr: Is there something I can improve on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CommonsMetadata/+/983714/ or would you prefer a different direction? [18:16:58] Krinkle: I think it's fine, I +1'd it. [18:17:56] I was just wondering out loud about skipping the ContentAlterParserOutput hook on non-canonical parses, but it's probably a bad idea. In any way, it's not related to the patch. [18:18:08] I can merge it later today. [18:18:47] okay, thanks :) [18:22:27] Reedy: https://gerrit.wikimedia.org/g/mediawiki/core/+/7731c6e914e7e0db5dcc1dd8a001c9bf6957c1e4/includes/specialpage/AuthManagerSpecialPage.php#729 [18:22:46] Yeah, I'd found that [18:22:57] https://phabricator.wikimedia.org/T354541#9442709 [18:23:10] But help != help-message [18:23:35] the way it's actually used for most existing AuthRequest classes is basically API field documentation [18:23:54] https://codesearch.wmcloud.org/search/?q=%27help%27+%3D%3E&files=includes%2Fauth&excludeFiles=&repos= [18:25:03] It's not exactly clear in the code, without some digging [18:25:13] so for example the help text for authmanager-userlogin-remembermypassword-help (the "keep logged in" checkbox) is "Whether the password should be remembered for longer than the length of the session" [18:25:19] And it also seems like it could be used for some of the messages [18:25:26] not super useful to show that on the login form [18:25:55] I'll take the blame for not properly documenting that [18:25:59] :) [18:26:34] it should probably be called apiHelp or something like that instead [18:26:46] Something like that would make more sense [18:27:18] The way the help can be used in other contexts gives a nicer output (smaller, lighter text etc) [18:27:29] I think in general help text on a form is too context-specific to add to AuthenticationRequest [18:27:43] you can add it in AuthChangeFormFields [18:40:51] And insert the help at that point? [18:40:56] help (message) [19:26:26] Reedy: yeah, in the hook you can just manipulate the form descriptor directly. The array key is going to be the same so you can just set $formDescriptor['username']['help-message'] = wfMessage(...); [19:27:42] For the core fields, LoginSignupSpecialPage::onAuthChangeFormFields is where that happens.