[11:42:03] Friday musing: I wonder if ObjectFactory should allow the services list to be specified as a reference to a class constant [11:42:22] so in extension.json, the wiring for MyApiModule could have "services": "\\MyExtension\\MyApiModule::SERVICES" [11:42:49] and then the single source of truth for the list of services would be more easily available in PHP (without parsing extension.json), and closer to the constructor [11:42:59] and it could help to avoid issues like https://phabricator.wikimedia.org/T355368#9471237 (cc zabe) [11:43:26] this would be similar to ServiceOptions with self::CONSTRUCTOR_OPTIONS, I guess [11:45:46] we already do something like this in PHP code sometimes, but it’s not currently possible in extension.json https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/957944/1/repo/includes/Content/ItemHandler.php [17:33:34] Lucas_WMDE: interesting race condition. I imagine it was limited to bare metal mw servers (not k8s). I suppose a fix could be to perform the sync between the graceful drain/depool and the fpm restart. I guess right now we sync first and then drain and then restart. [17:33:57] Possibly even in parallel with the drain to save a few seconds [17:34:12] Unlikely though given we're shrinking appservers quickly [17:35:50] I'm not sure constants will eliminate the issue. But it will make it less likely for this particular kind of patch. There would still be issues with hooks potentially, and any other class or method references in extension.json [18:02:48] We could potentially mitigate it by setting an indefinite TTL on configurations where opcache is configured to be immutable (ie no revalidations and fpm restarts only). That way this entry would naturally not change until after the restart [18:03:18] For the apcu cache key of ExtensionProcessor I mean [20:07:04] Google is updating their policy on email requirements for large volume senders, specifically they will require on-click unsubscribe support starting in February, https://phabricator.wikimedia.org/T355450 [20:07:31] Is anyone aware of this requirement on the mediawiki side? [20:58:32] I've added MediaWiki-Platform-Team to the phab task