[14:13:24] <Krinkle>	 Amir1: Hm.. trying to install TitleKey on latest master fails in update.php:
[14:13:38] <Krinkle>	 Creating titlekey table...Wikimedia\Rdbms\DBQueryError from line 1203 of /Users/krinkle/Development/mediawiki/includes/libs/rdbms/database/Database.php: Error 1: near "binary": syntax error
[14:13:38] <Krinkle>	 Function: Wikimedia\Rdbms\Database::sourceFile( /Users/krinkle/Development/mediawiki/extensions/TitleKey/sql/titlekey.sql )
[14:13:38] <Krinkle>	 Query: CREATE TABLE "titlekey" (  tk_page int unsigned NOT NULL PRIMARY KEY,  tk_namespace int NOT NULL, tk_key varchar(255) binary NOT NULL
[14:13:51] <Krinkle>	 I'm guessing this is because we removed mysql>sqlite automation 
[14:40:00] <Lucas_WMDE>	 stupid question: what’s the expected way for an extension to programatically register hooks?
[14:40:05] <Lucas_WMDE>	 https://www.mediawiki.org/wiki/Manual:Extension.json/Schema#ExtensionFunctions says that a callback should be used, but not how
[14:40:31] <Lucas_WMDE>	 and https://www.mediawiki.org/wiki/Manual:Extension.json/Schema#callback doesn’t explain this particular use case either, but it mentions that MediaWikiServices (and therefore the HookContainer service) aren’t available yet
[14:40:43] <Lucas_WMDE>	 should the callback just assign to $wgHooks, old school style? ^^
[14:41:51] <Lucas_WMDE>	 oh! SettingsBuilder has a registerHookHandlers method?
[14:41:57] <Lucas_WMDE>	 I didn’t see that
[14:42:01] <Lucas_WMDE>	 that sounds just like what I want then
[14:42:10] <Lucas_WMDE>	 (SettingsBuilder is passed into the callback, apparently)
[14:43:47] <Lucas_WMDE>	 ugh, no, that throws a fatal error
[14:43:48] <Lucas_WMDE>	 “SettingsBuilder::load only supported while still in the loading stage”
[14:43:49] <Lucas_WMDE>	  :(
[14:52:00] <bawolff>	 My assumption would be $wgHooks given how early an extension.json callback runs, but I don't have super high confidence that is accurate
[14:52:43] <Amir1>	 Krinkle: yeah, that looks like it
[15:56:13] <Krinkle>	 Amir1: Hm.. I don't suppose we have automatic sql->json conversion?
[15:56:31] <Amir1>	 nope, we have a script that helps
[15:56:39] <Krinkle>	 Is `varchar(255) binary` something we support in abstract or do we have to go change to varbinary while at it?
[15:57:10] <Amir1>	 https://github.com/Ladsgroup/db-analyzor-tools/blob/master/db_abstractor.py
[15:57:23] <Amir1>	 you have to go to varbinary
[16:00:56] <Krinkle>	 Hm.. so that means a one-off non-abstract schema change?
[16:01:38] <Krinkle>	 Or is there a (discouraged) way we can get it to output it via "type": "string" (VARCHAR) and set binary somewhere? I did try "collation" and "charset" but neither was allowed
[18:58:03] <tgr|away>	 Lucas_WMDE: CentralNotice does that: https://gerrit.wikimedia.org/g/mediawiki/extensions/CentralNotice/+/b6140a9994ae73f1304f01405560a425dc851aa0/includes/CentralNoticeHooks.php#54
[20:26:08] <Krinkle>	 Lucas_WMDE: depending on the issue, I'd probably not bother with conditional hooks and instead make the function perform the relevant check. That also reduces setup cost slightly, by deferring the check. And makes the logic testable.
[20:28:07] <Krinkle>	 But yeah, onRegistration is a reasonable place to do it if you can make the decision at that point already (without calling into any unsafe code).
[20:29:38] <tgr|away>	 OAuth used to do it in ExtensionFunctions, so at some point that worked too. But it was removed before SettingsBuilder was created, not sure if that affected it.