[00:15:40] <bd808>	 !bash  <    Amir1> Everything in mediawiki is a rabbit hole
[00:15:40] <stashbot>	 bd808: Stored quip at https://bash.toolforge.org/quip/BaPOz5UBffdvpiTrBEEr
[00:15:50] <Amir1>	 xD
[00:16:16] <bd808>	 I think my past formulation of that was something like "its edge cases all the way down"
[00:20:15] <Amir1>	 lol yup
[00:20:36] <Amir1>	 and hysterical raisins 
[00:23:08] <bd808>	 and/or half done migrations :)
[00:30:01] <Amir1>	 😭
[01:24:38] <Krinkle>	 Some of these deep migrations are like Zeno's parafox. You make an infinite number of ever smaller steps, and will appear to have finished it, but it is never fully done. See also: [[w:Exponential_decay]], [[w:Zeno's_paradoxes]], and <insert "He's only mostly dead" Princess Bride meme>
[01:26:15] <Krinkle>	 i.e. finding pre-2004 latin1 encoded values that have escaped migration scripts, or Amir1 a while back the pre-2004 'cur' table still hanging out in prod.
[01:26:31] <Krinkle>	 2004 was a good year :)
[01:26:37] <Krinkle>	 (for MediaWiki)
[01:26:43] <Krinkle>	 https://www.mediawiki.org/wiki/Manual:Old_table
[01:26:51] <Krinkle>	 True to its name, more than ever.
[17:01:04] <Krinkle>	 Reedy: does this rel note sound good? https://gerrit.wikimedia.org/r/c/mediawiki/libs/Minify/+/1131296/3/CHANGELOG.md
[17:01:26] <Reedy>	 I'm not 100% sure on the "or PHP 8.3"
[17:01:58] <Reedy>	 The better version would be...
[17:02:32] <Reedy>	 Actually, just dropping the "or PHP 8.3" would work
[17:02:49] <Reedy>	 I'm guessing you could run PHP 8.1 on PCRE 10.45 etc
[17:03:29] <Krinkle>	 see inline comment
[17:03:47] <Krinkle>	 https://gerrit.wikimedia.org/r/c/mediawiki/libs/Minify/+/1131296/2/CHANGELOG.md
[17:04:22] <Krinkle>	 I meant for "e.g." to carry that it isn't limited or explicitly that
[17:06:36] <Reedy>	 It's not just PHP on older PCRE... it's older PHP on newer* PCRE
[17:07:08] <Reedy>	 I guess in reality, it doesn't massively matter
[17:07:13] <Reedy>	 Who reads these anyway? ;)
[17:13:37] <Krinkle>	 added "likely"
[17:13:43] <Krinkle>	 >  Fix compat with PCRE 10.45, e.g. on Debian Trixie or PHP 8.3.
[17:13:56] <Krinkle>	 > Fix compat with PCRE 10.45, e.g. on Debian 13 or Ubuntu 25, and likely PHP 8.3+.
[21:24:10] <Reedy>	 Krinkle: Can we take tests passing on the release branches as the minify update is proably "ok" enough?
[21:40:44] <Krinkle>	 Reedy: yes.
[21:41:15] <Krinkle>	 Reedy: also tests in the Minify repo itself. it's fairly straight forward in terms of testing.
[21:41:29] <Reedy>	 yeah, it was more the "integration" part
[21:42:01] <Krinkle>	 ack, there's variuos minify calls in PHPUnit in core for RL, as well as qunit/selenium calling it end to end as part of their normal operation.
[21:42:54] <Reedy>	 And at least RL is reasonably well test covered https://doc.wikimedia.org/cover/mediawiki-core/includes/ResourceLoader/index.html
[21:44:19] <Krinkle>	 yeah, more if we let phpunit count uninhibited by @covers annotation claims
[22:03:16] <Krinkle>	 Amir1: fwiw the truncation bug seems to have stopped around Feb 2012, so I guess that's when either we fixed the language->trunc method and/or started applying it correctly to excerpts when generating automatic edit summary / log reason. ref T108434
[22:03:17] <stashbot>	 T108434: Some rows (from the year 2004) in SQL databases have text in latin1 encoding - https://phabricator.wikimedia.org/T108434