[15:12:04] Krinkle: do you know what needs to be done with https://phabricator.wikimedia.org/T378498 ? i wonder why the patches are marked as WIP (cc JustHannah) [15:15:02] MatmaRex: the approach in question doesn't work. There's some conceptaul incompatibilities in how Tim and I approached this originally. [15:15:06] there's no easy fix. [15:16:43] basically we need the source map to either skip over a chunk, which I've not managed to do reliably (the best we found was to output a token the size of the entire file, but that had the side-effect of forcing stack traces to map to the start or end of the file, never within it). Or to implement a mode within the minifier that doesn't minify, but still process every token and output it as-is to the source map. [15:16:56] That has to be done very precisely and seems to often be off by a few, it's hard to get right. [15:18:34] the way it's implemented, it assumes the bundle is either entirely minified or not. whereas nomin is a per-module concept. [15:24:31] ugh. thanks [15:25:19] i wonder, do we still need @nomin at all? afair it was mostly a workaround for us lacking support for modern JS syntax. but we have that support now. [15:33:36] Yeah [15:34:36] https://codesearch.wmcloud.org/search/?q=FILTER_NOMIN&files=php&excludeFiles=test&repos= [15:34:44] https://codesearch.wmcloud.org/search/?q=%40nomin&files=js%24&excludeFiles=test&repos= [15:35:08] Looks like it slipped back into AdvancedSearch by copying from an old pattern that core used to have [15:35:11] I thoguht I removed that already [15:36:20] it related to making sure minification of user.tokens isn't cached as that would explode php-apcu with unusable entries [15:36:28] but we've since excluded group=private automatically [15:36:37] so it's fine to minify those [15:37:18] I recall CX ran into some post-ES6 syntax recently and that's why they started using it again [15:37:42] but codesearch doesn't surface that anymore so I guess that's fixed by them compiling to ES6 and/or relying on the fact that we support those tokens now. [15:38:12] plus with the newline behaviour removed, new corruptiojns like that are less likely in general, even for future syntax [15:38:28] so yeah, maybe it's time to pull the plug [15:39:57] the three wikibase files pass eslint syntax check with es2017, one of them fails es2015 but passes es2017 [18:31:32] thanks fo rhte +2s Reedy, any idea when the aliases were removed? (I assume there were some?) [18:32:06] recently :P [18:32:14] Probably in the REL1_44 cycle [18:32:46] Which probably means they want backporting [18:33:12] yeah, i might just backport them into the past 1.40+ so i dont have to find when the aliases were removed? [18:33:29] https://github.com/wikimedia/mediawiki/blob/REL1_44/RELEASE-NOTES-1.44#L372-L376 [18:33:40] oh, sneaky [18:33:42] Just need to do into REL1_44 [18:33:49] You could do REL1_43 because LTS [18:33:59] REL1_42 is nearly EOL [18:34:10] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ConfirmAccount/+/1147840 https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ConfirmAccount/+/1147841 for 144 [18:35:01] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ConfirmAccount/+/1147843 https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ConfirmAccount/+/1147842 143 [18:36:18] ty [18:52:03] With Graphite going read-only, the "break down by user type/page type/entry point" panels no longer worked for Backend Save Timing at https://grafana.wikimedia.org/d/000000429/backend-save-timing. I've removed those now, and created a new Prometheus-based breakdown at https://grafana.wikimedia.org/d/aemdr1nwrsao0d/backend-save-timing-breakdown [18:53:02] This didn't work initially because the cardinality was way too high (in the migration, we combined all labels onto a single metric, and then someone added "wiki" as a label, which multiplied it by 1000). But that's since been fixed. Details at https://phabricator.wikimedia.org/T391677#10836645 [18:55:45] These now also embrace the buckets and heatmaps [22:14:50] almost immediately two bugs about new excimer [23:11:50] nice to know people are using it [23:20:33] can't easily reproduce though, it seems to work for me [23:24:00] I wonder how many of these are using :latest in some way or another and their builds magicly start failing [23:27:20] I'm trying with their dockerfile [23:30:08] WFM locally too [23:44:44] my docker setup is broken, will take a few more minutes to fix [23:44:49] I only use it for this sort of thing