[13:42:15] AaronSchulz: could use review on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1072816 to verify my understanding on lockmanager. [14:17:05] Krinkle: I guess removing the constants doesn't break @stable to extend since https://www.mediawiki.org/wiki/Stable_interface_policy says nothing about constants. ;) [14:31:57] AaronSchulz: hmm I didn't think of them as for subclasses, they may as well have been private or @internal. They're unused either way. Happy to add a release note if you like. [14:33:12] No subclasses outside code at all at the moment according to Codesearch "Eveywhere", so it's all a bit hypothetical. [15:47:01] Krinkle: oh, I don't care either way, I'm just curious about the policy itself. I was snarking about 1021363 again mostly :)