[15:37:48] 3 big folders to go in includes... [15:37:54] Actions, Block and Specials [15:38:31] (ignoring patches in Gerrit) [16:13:37] and now it's doing silly failures :( [16:21:11] https://integration.wikimedia.org/ci/job/quibble-with-gated-extensions-vendor-mysql-php81/10697/console why did that fail [16:29:06] o_O I can’t tell either [16:29:18] “Build step 'Execute scripts' changed build result to FAILURE” [16:30:32] some cleanup vagueness? [16:31:03] it feels suspicious that it didn’t report a corresponding castor job [17:13:24] Another weird failure [17:13:44] https://integration.wikimedia.org/ci/job/mediawiki-core-php81-phan/19069/console [18:05:24] Reedy, this task https://phabricator.wikimedia.org/T282893 is a common thing I see with those weird failures [18:05:30] Not sure if they're related or something [18:07:45] Looking at some of the patches associated with that task, it seems like that should be it. I see some log suppression going on there, but I don't have a full understanding :( [18:38:42] hah [18:38:49] seriously flaky tests if that installer one now merged [18:45:46] Reedy, do I have the magic touch? :D [18:46:08] Apparently so today :P [19:05:20] love it when something gets merged but gerrit says merge conflict [19:49:27] I guess we're going to have some phan fighting to finish off these last few... [21:24:14] So block and actions are going to be the painful ones [22:22:30] Apparently not, Block doesn't seem to care anymore [22:22:33] Specials similarly [22:56:30] cscott, xSavitar, zabe: That's pretty good going that in a week we've got down to basically 2 folders left (and one isn't even throwing anything) [22:56:37] tests to tidy up more wholesale afterwards [22:57:09] i've been tidying up tests as we go, but there's some messiness there for sure. [22:57:42] what i've been wondering if whether i'm brave enough to try a "real" PSR-4 autoloader for tests, given that there are large chunks of the tests/ directory now which could be mapped that way. [22:58:34] I wonder if that becomes any better/worse after the PHPUnit 10 upgrade [23:00:34] There are also a few classes that aren't properly namespaced still. I haven't been touching those because I assume that there's "some good reason", but eg even aside from the classes which have no namespace at all, there are things like `includes/Language/Message` being in the `MediaWiki\Message` namespace. [23:01:30] I noticed that `includes/RecentChanges/RCFeed` was moved to top level, maybe `Message` should be as well? [23:02:30] A lot of namespacing just is a case of people haven't bothered (yet) [23:02:47] also speaking of specials, `tests/phpunit/includes/Api/Query` exists with `namespace MediaWiki\Tests\Api\Query;` but on the code side there's no Query subdirectory or subnamespace. [23:03:49] we seem to make a mess of namespacing in various cases... [23:04:05] Pager folders in many other folders, but they're only root MediaWiki\Pager... [23:04:28] i've been doing the test directories because it's a pet peeve of mine already that there are already three different places to look for a test case for a class X, and the thought of having to double that by trying upper and lowercase versions of the directory names makes me cranky. [23:07:11] Yeah the original namespace bug https://phabricator.wikimedia.org/T166010 wasn't particularly specific about where things should go. [23:42:55] 22:55:19 includes/Parser/ContentHolder.php:248 PhanTypeMismatchReturnNullable Returning $this->pageBundle of type ?\Wikimedia\Parsoid\Core\BasePageBundle but getBasePageBundle() is declared to return \Wikimedia\Parsoid\Core\BasePageBundle (expected returned value to be non-nullable) [23:42:55] 22:55:19 includes/Parser/Parser.php:2145 UnusedPluginSuppression Plugin BuiltinSuppressionPlugin suppresses issue SecurityCheck-XSS on this line but this suppression is unused or suppressed elsewhere [23:43:17] https://integration.wikimedia.org/ci/job/mediawiki-core-php81-phan/19131/console [23:43:25] The random failures on there...