[00:32:47] current LCStoreStaticArray on my test box: total cache size 718 MB (147 MB gzipped). With my current simplified patch: 119 MB (27 MB gzipped) [00:33:05] and saves 300 megabytes in opcode cache after touching all the localizations :D [00:33:33] expect bigger savings on production with extra extensions [00:34:24] versus CDB of 855 MB (229 MB compressed - yeouch!) [00:35:02] also generation time on CDB is 93 seconds vs 22 seconds current LCStoreStaticArrays vs 3 seconds for patched 😎 [00:35:48] so that should end up being a big improvement on deploy times: shorter generation time, smaller files to distribute over the network [00:36:59] i can save at most 10 megabytes RAM on this setup with the message indirection, since the strings have to get loaded anyway, so i think it's wise to take the conservative approach and drop the common key indirection file with all its locking complications [00:37:51] but by replacing 'messages:foo' with 'messages' => [ 'foo' ] i've reduced the duplication in the files and strings anyway versus what it was doing before :D [11:33:39] Wow, that's massive. [17:26:09] JustHannah: less.php PHPUnit CI is now passing on PHP 8.5, nice work! [17:26:31] I've pushed a patch at https://phabricator.wikimedia.org/T411213 to disable Phan for now, since we don't need it on every PHP version separately. You can do the release after that?