[04:31:36] I want to add in-process caching to ProxyLookup, so I'm adding a BagOStuff $cache parameter to the constructor. Does it need to be optional, for back-compat? ProxyLookup is only instantiated via ServiceWiring, but I don't know if that contract extends to extension code. [08:27:44] looks like only CheckUser uses ProxyLookup [08:27:54] There's always extensions that do stupid shit, don't worry about them too much [09:03:06] ori: classes aren’t stable to construct by default (https://www.mediawiki.org/wiki/Stable_interface_policy) and ProxyLookup isn’t marked stable to create, so adding a constructor param should be fine [09:03:23] (you might have to update CheckUser first if core’s CI includes it, I don’t know)