[01:33:04] <Amir1>	 Random idea of moving code around in core to make it much more modular:‌ T417605 (basically the low hanging fruits)
[01:33:05] <stashbot>	 T417605: Break asymmetric direct cyclic dependencies of top level components of mediawiki core - https://phabricator.wikimedia.org/T417605
[01:33:25] <Amir1>	 if you have any ideas, I'm all ears!
[01:33:47] <Amir1>	 This can give a good list of stuff to do: https://phabricator.wikimedia.org/P88835
[05:15:56] <Krinkle>	 Is there a standard practice (other than force merging) for syncing Parser tests in an extension like Cite when a core patch changes the output? https://gerrit.wikimedia.org/r/1239818 /cc cscott
[05:51:02] <cscott>	 Krinkle: yes: https://wikitech.wikimedia.org/wiki/Parsoid/Common_Tasks#Sync_parser_tests
[05:52:31] <cscott>	 although you're doing something slightly different, it looks like
[05:53:52] <cscott>	 also we just landed https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1227492 this week, which seems related.  I think it would be not great if you removed the 1.5x srcset for that, though?
[05:55:09] <cscott>	 maybe it would be fine.  we should coordinate, though.  See eg https://phabricator.wikimedia.org/T417515
[06:00:27] <cscott>	 Krinkle: generally speaking we have a number of strategies to deal with cyclic dependencies in parser tests like the one you're dealing with.  One is to have a patch which adds `disabled` to the options section of all the affected tests, and then a follow up which removes disabled + update the html.  Something like this:
[06:00:56] <cscott>	 https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cite/+/1189220 which depends on https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/1187921 which depends on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cite/+/1189240
[06:03:40] <cscott>	 a slightly more elegant solution is to adjust the "normalization" done by parser tests to eliminate the difference being made.  Example, the changes to TestUtils in https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/992274 and https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/1217724
[06:04:16] <cscott>	 you could probably easily add a test normalization which stripped out `srcset` entirely for your transition period.
[06:18:46] <cscott>	 I put all of this on-wiki at https://www.mediawiki.org/wiki/Manual:Parser_tests#Breaking_cyclic_dependencies
[08:53:41] <A_smart_kitten>	 (FWIW I am looking forward to circular dependencies https://zuul-ci.org/docs/zuul/latest/config/queue.html#attr-queue.allow-circular-dependencies potentially being/becoming a possibility if/when a Zuul upgrade happens... at an initial assessment, it seems like the type of thing that could potentially come in useful sometimes)