[08:51:12] It says that in the restbase repo? [08:51:38] Codesearch finds that sentence in the changeprop repo. https://gerrit.wikimedia.org/g/mediawiki/services/change-propagation/deploy/+/464d3bcc59e68764be3e3765e5511e2e3eff4559/README [15:24:34] do we consider it a bug if a test suite fails when LocalSettings has a non-default $wgLanguageCode? [15:26:37] Yes. [15:27:39] See MediaWikiLangTestCase [15:28:11] default in base class is qqx which should take care of most things. [15:28:21] This subclass is for cases where content lang matters as well [15:28:28] Maybe we should make that default as well. [15:29:03] One step at a time ref T277470 [15:29:04] T277470: Ignore (most) of LocalSettings.php when running PHPUnit (fix surprise test failures) - https://phabricator.wikimedia.org/T277470 [15:29:46] thanks. fwiw, the context is that SpecialMovePageTest fails in that case because it depends on english namespace names [15:33:48] can't use MediaWikiLangTestCase there because it needs SpecialPageTestBase methods, but https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1339804 is easy enough to do without it