[20:28:42] do we think this comment https://gerrit.wikimedia.org/g/mediawiki/extensions/AbuseFilter/+/6c7844b4eaea04f1be8160297d0d2d7f286be798/includes/Parser/AFPToken.php#9 is specifically trying to restrict that file to what we today would call GPL-2.0-only (while the rest of AF is -or-later) or is that just a not-that-specific comment stating the same [20:28:42] license as the rest of the project [20:34:47] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/327944 [20:34:48] https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/AbuseFilter/+/fc0b18e2d689e47ec01342e970f248f81097d9e1%5E%21/AbuseFilter.parser.php [20:35:11] https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/AbuseFilter/+/fc0b18e2d689e47ec01342e970f248f81097d9e1/ [20:35:18] That's SVN era [20:35:39] COPYING for the repo as a whole was aded after that point in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/AbuseFilter/+/fc0b18e2d689e47ec01342e970f248f81097d9e1/ [20:35:47] At the time that file was the main file with all classes in it [20:35:54] for some reason Aaron copied it only to that one class [20:36:12] so if that is to be taken that way, it would be a statement for the repo as a whole more or less [20:40:16] taavi: I'd say remove it. [20:40:56] Neither Victor nor Andrew were known to have specific opinions about the GPLv2 to my knowledge. [20:41:29] works for me, I'll make a patch [20:41:57] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/107764 added the COPYING file several years later [20:42:17] so we can forward any legal complaints to Reedy (j/k) [20:46:53] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/1366724 [20:47:38] * Krinkle pushes the shiny button [20:52:54] Krinkle: thanks. the other similar case I noticed was https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/skins/MonoBook/+/refs/heads/master/resources/screen-common.less#4 . as far as I can tell, that dates from the times when monobook was a part of core, so given we've treated all of core as -or-later I would do the same here as well? [20:56:01] indeed. https://github.com/wikimedia/mediawiki/blob/REL1_23/skins/monobook/main.css [20:56:51] https://gerrit.wikimedia.org/r/c/mediawiki/skins/MonoBook/+/1366729 [20:56:54] 2004: https://github.com/wikimedia/mediawiki/commit/c556555c8706fc9a2ffe341e1904fb6b6d640e0a [20:56:59] It used to just say "GPL" without a link even [20:57:13] and http://www.gnu.org/copyleft/gpl.html is a redirect to v3 for what its worth [20:57:17] oh, that comment is older than me then [20:57:29] ^_^ [20:57:36] v3 was not out by that time :D [20:58:02] TIL you are post-2000. [20:58:07] The math adds up, I just hadn't thought about it.