[10:40:02] <Guest67>	 Hi guys, since I upgraded to 1.35 I get "Call to protected method BaseTemplate::getSidebar()". I try to get the toolbox and am doing $toolbar = $this->template->getSidebar(); With 1.31 it did work, now it's not more working. Does anyone has an idea how to fix it?
[14:15:33] <ashley>	 Guest67, is that happening in a custom skin of yours or...?
[14:19:28] <ashley>	 Guest67, should all else fail you can probably hack around the restriction imposed by the "protected" keyword with reflection, like so: $r = new ReflectionMethod( $this->template, 'getSidebar' ); $r->setAccessible( true ); $toolbar = $r->invoke( $this->template );
[14:20:05] <ashley>	 (this is similar to what I'm doing in [[mw:Skin:Nimbus]], the buildActionBar() method in /skins/Nimbus/includes/NimbusTemplate.php)
[15:01:01] <Reedy>	 ashley: We can public... But it wasn't used in a public context when searching our codebases :P
[15:08:02] <Guest67>	 Hi ashley yes it's a custom skin, but was coded about 5-6 years ago from a dev. I'll try your suggestion
[15:12:26] <ashley>	 Reedy: public should certainly be the de facto default for old methods, but randomly changing stuff from public to non-public is...annoying, to say the very least >.>
[15:12:46] <Reedy>	 it does lead people to using things as public that never should've been :P
[15:13:07] <ashley>	 Guest67: you should consider publishing its source on gerrit.wikimedia.org to potentially avoid such issues from occurring in the future and to get some code updates from other MW devs etc. :)
[15:13:12] <ashley>	 > that never should've been
[15:13:15] <ashley>	 [citation needed]!
[15:18:03] <Guest67>	 ashley looks like it's working, at least now I see a new error... Call to protected method BaseTemplate::getFooterIcons() 
[15:18:40] <Guest67>	 Are we not supposed to use this functions?
[15:18:55] <ashley>	 oh, that's a clusterfuck, alright :D see https://phabricator.wikimedia.org/T278266 etc.
[15:19:58] <ashley>	 (I'm tempted to say that it's beyond me why a function used widely in roughly every semi-maintained skin ever was deprecated/removed, but then again it's hardly the first -- nor the last -- time that's happened in MW history, so I don't even...)
[15:20:49] <Guest67>	 Oooh God, Moses and Lucifer... I hope I don't have to update to much stuff. I'm new to php and mw D: 
[15:21:35] <ashley>	 get used to it >.>
[15:21:52] <Guest67>	 yeap
[15:29:07] <Guest67>	  ashley seems also to work. Now I hope that there are no more error regarding this stuff 
[15:29:30] <ashley>	 \o/
[21:35:53] <Guest8289>	 Hello, I upgraded SMW to 3.2.3 and Semantic Result Formats to 3.2.0 and now I'm getting "Error: Unknown module: jquery.ui.core" does anyone know how I can fix this?
[21:44:50] <Reedy>	 Depending on what's actually complaining, reporting it to the right place (ie SMW or SRF)
[21:45:02] <Reedy>	 jquery.ui.core was a seperate RL module in 1.31... That changed at some point
[21:45:26] <Reedy>	 looks like in MW 1.35
[21:45:53] <Guest8289>	 So it's not more supported?
[21:50:49] <Reedy>	 What is it?
[22:12:44] <ashley>	 Guest8289: so basically you want to replace all individual jquery.ui.<some module name> instances w/ just plain jquery.ui; they were all merged into one mega-module in 1.35 because jQuery UI is allegedly deprecated
[22:13:05] <ashley>	 (I do wanna note that I think it was a very incorrect decision, though)
[22:51:18] <Guest8289>	 ashley what does that mean "one mega-module"
[22:52:08] <Guest8289>	 for example if I want to use "jquery.ui.datepicker"
[22:52:17] <Guest8289>	 what do I need to do?
[22:52:24] <ashley>	 there's no jquery.ui.core, jquery.ui.dialog, etc. ResourceLoader modules anymore, there's just jquery.ui; anything attempting to use, for example, jquery.ui.dialog instead of jquery.ui will fail; this also means that you can't load only the bits 'n' pieces you need of the whole jQuery UI library, you gotta load the whole thing
[22:52:29] <Guest8289>	 Do you have a link where I can read about it?
[22:53:47] <Guest8289>	 hmmm VM3867:1 Uncaught ReferenceError: jquery is not defined
[22:53:47] <Guest8289>	     at <anonymous>:1:1
[22:54:05] <Guest8289>	 looks like I also don't have jquery 
[22:54:11] <Guest8289>	 jQuery works
[22:54:21] <Guest8289>	 maybe something is missing
[22:54:33] <Guest8289>	 where does this jquery.ui come from?
[22:55:29] <moonmoon>	 double-check your SMW version and ensure it's compatible with your MediaWiki version
[22:55:45] <moonmoon>	 same with SRF
[22:55:45] <ashley>	 https://phabricator.wikimedia.org/T219604 -- here's the ticket re:merging jquery.ui.* RL modules into jquery.ui
[22:56:24] <Guest8289>	 no it's not SMW, I did look at the wrong thing
[22:56:46] <Guest8289>	 but some custom extension are using e.g. jquery.ui.datepicker
[22:56:58] <Guest8289>	 or jquery.ui.sortable
[22:57:10] <ashley>	 AFAIK jQuery has always been usable as jQuery or $ but not as jquery because JS is case-sensitive
[22:58:28] <Guest8289>	 upgrading mw is always such pain in the ass
[23:00:08] <ashley>	 indeed
[23:00:15] <ashley>	 and with certain extensions, even more so
[23:00:38] <ashley>	 anyways, it seems that SRF hasn't really been updated for 1.35(+) based on a quick look at the various jquery.ui.* module names in https://github.com/SemanticMediaWiki/SemanticResultFormats/blob/master/Resources.php
[23:01:44] <Guest8289>	 I think SRF is good to go
[23:02:03] <ashley>	 you may also be interested in https://github.com/SemanticMediaWiki/SemanticResultFormats/issues/619 and https://github.com/SemanticMediaWiki/SemanticResultFormats/pull/621
[23:03:29] <Guest8289>	 if I have to rename everything to jquery.ui like here written https://phabricator.wikimedia.org/T219604 
[23:03:44] <Guest8289>	 why do I get Uncaught ReferenceError: jquery is not defined
[23:03:45] <Guest8289>	     at <anonymous>:1:1
[23:04:05] <Guest8289>	 where do I get jqeury.ui
[23:04:19] <Guest8289>	 Am I maybe missing something
[23:06:00] <Guest8289>	 or should it not be available in the browser console. I see it's also not available on the mediawiki.org page
[23:11:36] <moonmoon>	 it is not available in the browser console, no
[23:11:44] <moonmoon>	 it's a module, not a variable
[23:12:03] <moonmoon>	 the stuff it adds gets populated under the jQuery/$ object
[23:14:43] <Guest67>	 Helo
[23:14:46] <Guest67>	  I am the pog ???
[23:14:51] <Guest67>	 i think i am the pog ...
[23:14:53] <Guest67>	 so yea
[23:14:54] <Guest67>	 gjisdvkzcl, x
[23:14:55] <Guest67>	 fj
[23:14:56] <Guest67>	 dapoikmv l
[23:14:57] <Guest67>	 ijfokdlscvm 
[23:15:07] <Guest67>	 anyways ,,,
[23:15:10] <Guest67>	 what 1+1 ???
[23:15:12] <Guest67>	 ig ...
[23:15:23] <Guest67>	 haoaha
[23:15:23] <Guest67>	 hadog
[23:15:40] <Guest67>	 p
[23:15:41] <Guest67>	 ijdozcvmxc
[23:15:43] <Guest67>	 jikpmlv xcb
[23:15:44] <Guest67>	 [okml;,.v x
[23:15:44] <Guest67>	 {OL;.,
[23:17:18] <Guest8289>	 ok moonmoon