[10:10:40] got tired of copy-pasting URLs and hacked together some bad shell functions, oops https://paste.ee/p/ghyM7 [10:48:18] hmm database migration for 1.35.2 to 1.36.1 fails [10:51:35] https://paste.ee/p/QXGXS do I report this as a bug [10:57:58] there is a user_properties_property index [10:59:09] found a patch file that adds user_properties_user_property but hmm [11:02:47] it seems like the index is only created if the table does not exist? [11:05:26] Remilia: I'm not a developer, but I'll need to do 5x that same 1.35.2 -> 1.36.1 upgrade so I'm interested [11:05:48] Iamthehuman1: you probably are not using both PostgreSQL and Visual Editor [11:05:51] sorry to hear you are having problems [11:06:08] I'm using MariaDB and no Visual Editor [11:07:00] I think I may have found out what happened in my case, VisualEditor messed stuff up and then during a later migration the index was not created as expected [11:25:07] may have found a bug in the schema update for PostgreSQL [11:26:48] just one? [11:27:46] Reedy: yes, aside from questionable issues with the user_properties table [11:29:52] Reedy: https://github.com/wikimedia/mediawiki/blob/REL1_36/includes/installer/PostgresUpdater.php#L390 [11:30:31] "[ 'changeField', 'watchlist', 'wl_namespace', 'INT', 0 ]," is impossible to perform because wl_namespace is in an index, and MW by default always has more than just the 0th namespace [11:30:37] in the watchlist [11:31:22] the page + its discussion page are added to the watchlist table which means replacing every wl_namespace value with 0 will hit unique constraint [11:31:47] You're best filing bugs for this sort of thing [11:31:55] I guess I will [11:43:48] Reedy: if you have a bit of time, can you check T286779 and see if it decently explains the issue? [11:43:49] T286779: MediaWiki installer: error in PostgreSQL schema upgrade for REL1_36 and beyond - https://phabricator.wikimedia.org/T286779 [13:22:15] hmm how do I specify new Vector settings… [13:35:29] I think I found it though cannot find how to enable the new search widget yet [13:48:53] all right, now I just need to know how to make it show images in search suggestions :| [14:05:32] Remilia: good question: enWS could do with that too [14:06:39] `wvui-typeahead-suggestion__thumbnail-placeholder` isn't really ideal either because it make it look like every page is actually an image [16:52:46] inductiveload, my issue is just that it shows placeholders for every result, even though the pages do have images (usually multiple) [16:53:51] wonder if the image needs to be tagged somehow [17:22:40] Idk either, I thought maybe it might be a magic wikidata thing [17:23:04] But seems not because even pages with WD items that have images don't come up [17:34:26] What API request is it making? [18:25:20] I will take a deeper look into this tomorrow to see which request it is [18:25:32] spent all day today dealing with breakage after upgrading ahaha [18:26:10] (SimpleMathJax broke for MinervaNeue for me and I have no idea why, and the older version I used with 1.35.2 seems to work) [18:33:03] Hi guys, I'm on mw 1.35 and am experimenting with Hooks. I can't get the Hooks onPageContentSaveComplete and onPageSaveComplete to work. For testing I added also onOutputPageBeforeHTML and this is working. Do I have to do something special with the two hooks? [18:33:40] I simply took the examle from https://www.mediawiki.org/wiki/Manual:Hooks/PageSaveComplete and added an echo to it [18:33:56] echo isn't going to be an effective form of debugging for most hooks [18:34:12] for the saves in particular, the wiki output returns a redirect to the saved page [18:34:18] which your browser dutifully follows [18:34:27] which would wipe any echoed output since that causes a new page load [18:34:49] if you need to log messages inside of a hook, use $wgDebugToolbar = true; combined with \MWDebug::log(...); [18:37:16] so simply swap echo with \MWDebug::log(...); ? [18:37:25] ok I'll try that [18:40:11] make sure to enable the debug toolbar as well, otherwise the log messages won't have anyplace to show [20:09:04] alternatively you can set up Monolog [22:02:25] Hi guys, I still don't know why public static function onOutputPageBeforeHTML( $outputpage, &$text ) {...} is working but onPageContentSaveComplete or onPageSaveComplete isn't working [22:03:15] Do I need to do something special? onPageSaveComplete should trigger when publishing an article right? [22:04:11] in the extension.json is also PageContentSaveComplete and PageSaveComplete set like OutputPageBeforeHTML [22:04:37] Does anyone know why onPageSaveComplete is not working? [22:06:01] Manual:Hooks is saying --> 1.35 PageSaveComplete After an article has been updated. and I'm on mw 1.35.3 [22:24:08] There's not enough information to be able to give you any help [22:27:15] What do you need Reedy? [22:28:08] Potentially linking to your code [22:30:16] Reedy it's simple the example code from https://www.mediawiki.org/wiki/Manual:Hooks/PageSaveComplete and I added instead the 3 ... --> MWDebug::init(); [22:30:16] MWDebug::log('Test log message'); [22:30:50] with onOutputPageBeforeHTML I get the message in the debug toolbar console [22:31:20] for onPageSaveComplete or onPageContentSaveComplete nothing is printed to the console [22:31:42] That doesn't sound surprising [22:31:53] why? [22:31:58] have you checked the on-disk logs? Things in the html view are only the things that happen before that view is rendered [22:32:05] ^ [22:32:14] That hook is only called in a DeferredUpdates [22:32:19] So it's run "later" [22:32:46] so it doesn't show in the debug console? [22:32:48] * bd808 is not a fan of the mwdebug toolbar for this reason [22:33:01] It's not guaranteed to, no [22:33:24] so how can I test if the Hook is working? [22:33:39] Why do you need to test it's working? [22:35:21] because there is an issue with an older custom extension and the code which is in the function onPageContentSaveComplete seems not to work [22:35:37] What is it trying to do in it? [22:35:40] and I want to know if there is an issue with the hook itself [22:35:56] only one line SolrSearch::getSingleton()->updateIndex($article); [22:37:17] the code is about 5 years old, so first I wanted to know if the hook itself is still working [22:37:21] Well, there's no $article parameter in that hook subscriber example [22:37:34] PageSaveComplete was only added in 1.35 [22:39:14] I know [22:39:30] the original hook is public static function onPageContentSaveComplete(WikiPage $article, User $user, Content $content, $summary, $isMinor, $isWatch, $section, $flags, $revision, Status $status, $baseRevId) [22:40:30] on https://www.mediawiki.org/wiki/Manual:Hooks/PageContentSaveComplete it says This deprecated feature should no longer be used, but is still available for reasons of backwards compatibility. This feature was deprecated in version 1.35.0. Please see PageSaveComplete for an alternative way to use this feature. [22:40:41] to me it sound it still should work [22:41:37] with 1.31 the hook works [22:42:49] It should... PageContentSaveComplete wasn't removed until 1.37