[00:32:03] Bert: 1) no, I doubt you missed anything 2) it's probably just a classic case of "the uploading code is awful and will cause you a headache if you look at it too closely", hence why no-one ever thought of adding such a hook; patches welcome! ;) 3) this is fine, I think? (there's also #wikimedia-dev but it's more of a...bot playground, I'd say; whereas this is better for actual human interaction and such) [10:39:18] ashley: thank you for your response! I was already fast asleep by that time, but now checking IRC between work :) We did feel like the upload code was a bit of a mess. We also ventured into the MIME code, and it seems to be fairly dated (PHP has gotten much better at MIME, making the MW fixes hacks/patches obsolete or sometimes they don't even work as well as PHP does nowadays) [10:39:49] can we just go and add a hook in a patch and throw that on Phabricator? We were guessing that wasn't really how things were done, but if it's just that, that would be great :) [10:41:07] indeed, the last time the upload code received significant work was during MW 1.16; patches (w/ associated Phab tickets) are most welcome! (it has gotten harder and harder to get a core patch in but for what it's worth I'm more than happy to +1 and maybe even +2 such a patch, provided there are no objections!) [10:44:15] ashley: so we file bugs for anything upload code related that seems buggy/inconsistent (including MIME if we're brave) and then file patches with that (or separate, would need to check how phabricator wants it). Did I understand that correctly? [10:45:08] yup, sounds good to me! [10:45:21] our student organisation has often submitted patches to FOSS projects (it's part of our core values), but we've always been a bit "afraid" of submitting to mediawiki :P [10:46:55] things certainly have changed in the last 10+ years and not always for the better, alas... [10:47:31] well, with a big project and a lot of people, things are bound to get a bit more procedural and impersonal, that's why I suggested to my friends we should ask on IRC first what to do :P [10:48:18] ashley: if we were to write such a patch to include a hook, would that only land in 1.37, or could it be backported to 1.36 and 1.35 you think? [10:48:24] I have no idea what procedures are like [10:48:57] we don't really backport new features to release branches, so it'd only make to 1.37 (if you can make the branching deadline in a few weeks) [10:49:21] I see, that's sad news :/ [10:49:27] we try to keep things on LTS [10:49:48] since updating mediawiki is very difficult for the student organisations we're trying to help with our extensions [10:50:15] I was hoping since it's unexpected behaviour, we might get a backport going, but I understand it's usually not done [10:50:19] Bert: fyi, for now we use Gerrit instead of Phabricator's code review tools, it might be a little difficult to use if you're not used to it but https://www.mediawiki.org/wiki/Gerrit/Tutorial should be helpful [10:50:37] oh ok, thx majavah :) [10:50:52] also feel free to add me as a reviewer, happy to help too even if I'm not familiar with the uploading code [10:51:07] I'll pass it on, since I'm more of the coordinator than the guy who's writing the patches in this case (I was supposed to be uninvolved, but look where we're now :P ) [10:51:16] majavah: thank you :D [10:53:41] BTW: our team is really happy to hear all this! I'm passing on the messages. Thanks again ashley and majavah :D [10:54:19] you're welcome; looking forward to your patches! [10:55:45] I think one of my colleagues also found one (or several) bugs specifically in the upload API code, so I will try to motivate him to also write patches for those, and then we can do several submissions [14:19:09] is someone bored enough to review a literally half-line patch fixing an issue in REL1_36 and master? :P https://phabricator.wikimedia.org/T290489 [15:22:17] Ostrzyciel: looks like you got your +2s? [15:22:33] yes I did, thanks! :) [15:38:07] I'm trying to undelete a page server side (https://github.com/miraheze/mediawiki/blob/REL1_36/maintenance/undelete.php) as on wiki is timing out but it's still stuck [15:38:31] is there a way to just know how to manually correct it? [15:38:56] it's 2 revisions [15:39:24] like print the SQLs to run so I can execute them DB side [15:39:25] Not unless you want to add/delete numerous DB rows manually [15:39:42] Reedy: it's 2 revisions so like 3 rows I'd guess [15:39:54] If it's timing out... It wouldn't necessarily work run db size [15:40:02] *side [15:40:04] Depends which part its stuck on [15:40:59] Reedy: only error I can see is a lock wait timeout [22:04:39] legoktm: do you know more about the CentOS note on https://www.mediawiki.org/wiki/MediaWiki_1.35? [22:05:14] The information there seems contradictory. It is recommending enabling "SC" but also stating that doing so broke MW, but then saying that actually it's been fixed.. [22:06:26] I think the problematic part is the name of the ticket is is used as the link text [22:07:20] or if the link was removed, "Red Hat 8 and CentOS 7 users should ensure Software Collections (SCL) is enabled to use PHP 7.3." or something [22:07:27] yep, reading through the ticket it's saying that SCL contains 7.3.20 [22:07:42] surprised it's needed on 8 though [22:07:46] my guess is that stock CentOS/RHEL doesn't have 7.3, so you need to use SCL to get the newer version [22:08:07] =\ [22:08:15] stock RHEL 8 is still 7.2.24 [22:08:20] so yeah SCL is needed there too [22:09:18] oh 8 uses appstream [22:09:27] so you e.g. dnf install php:7.4 [22:09:46] we may want to edit that notice to recommend scl only on 7 [22:12:50] or remove the note entirely and assume that people know how to install semi-recent versions of PHP on the servers they administer [22:13:00] (some may choose to e.g. use remi's repos instead of scl) [22:17:57] I think moving it lower on the page would be appropriate now that it's fixed [22:36:45] legoktm: I'd rather remove it entirely and just make sure our installation docs mention appropriate ways to get more modern PHP versions on those OSes [22:36:54] (which it already does) [22:37:21] might just be bold and do that [22:38:21] or maybe replace with a link to the install guide section that discusses getting modern PHP versions [22:38:28] that way the info is still there [22:43:56] moonmoon: sounds good to me then [22:44:09] moonmoon: legoktm https://www.mediawiki.org/w/index.php?title=MediaWiki_1.35&diff=4798216&oldid=4662564&diffmode=source [22:52:44] Krinkle: tweaked it to read https://www.mediawiki.org/w/index.php?title=MediaWiki_1.35&diff=4798317&oldid=4798220 [22:53:06] can re-mark for translation if that sounds good; felt making the new sentence a brand new translation unit rather than re-using an existing unit was best [23:00:12] LGTM