[15:28:16] <Yaron>	 Hi - I'm having Jenkins validation problems; hopefully someone here can help. It's with my Flex Diagrams extension. Here's the patch where I tried to fix it, to no avail: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlexDiagrams/+/724559
[15:29:11] <Yaron>	 And here's the Jenkins output: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-noselenium-docker/111047/console  The relevant error message seems to be "ReflectionException: Method TextContent::getHtml() does not exist" (which is strange, because it does exist).
[15:30:48] <Yaron>	 In Flex Diagrams, the method TextContent::getHtml() gets overriden by a few subclasses. I thought the issue was that this method is protected and the subclasses' corresponding methods are public, so I changed them to protected, but that didn't seem to make any difference.
[15:33:34] <Reedy>	 Not quite
[15:34:14] <Reedy>	 getHtml doesn't exist on master, and seems to be made using reflection magic
[15:34:22] <Reedy>	 From TextContentHandler.php
[15:34:23] <Reedy>	 			// Temporary changes as getHtml() is deprecated, we are working on removing usage of it.
[15:34:23] <Reedy>	 			if ( method_exists( $content, 'getHtml' ) ) {
[15:34:23] <Reedy>	 				$method = new ReflectionMethod( 'TextContent', 'getHtml' );
[15:34:23] <Reedy>	 				$method->setAccessible( true );
[15:34:23] <Reedy>	 				$html = $method->invoke( $content );
[15:34:57] <Yaron>	 Oh... sorry, I thought I looked at the current MW code, but I guess I was looking at the wrong thing.
[15:36:04] <Yaron>	 Okay, yes, now I see it too. Thanks a lot.
[15:36:23] <Reedy>	 https://github.com/wikimedia/mediawiki/commit/a68e641f9d4f6f71cfb6ef6584a0c9cdaf17287f
[15:36:47] <Reedy>	 Though, it seems to have been removed without deprecation
[15:37:04] <majavah>	 I guess the ReflectionMethod will fail to create if that the method is declared on the subclass and not on the TextContent class itself?
[15:39:13] <Yaron>	 majavah: yes, probably - though it's good that it does, because with the latest MW code, the FD extension just won't work.
[15:40:18] <Yaron>	 Reedy: yes, it was removed without deprecation, which is not ideal, but so be it. Do you happen to know what the recommended new approach is? I can't figure it out from looking at the code.
[15:41:15] <Reedy>	 I guess override fillParserOutput
[15:41:33] <Reedy>	 Depends what you're doing
[15:41:42] <Reedy>	 As if getHtml() doesn't exist... it should just do
[15:41:42] <Reedy>	 $html = htmlspecialchars( $content->getText() );
[15:44:59] <Yaron>	 Okay - well, fillParserOutput() seems to have moved from the Content to the ContentHandler classes, so that looks like the approach that extensions need to take.
[20:10:08] <puff>	 Hi. I just set up a semi-private mediawiki.  That is, it's public, but editing requires creating an account with an email confirmation loop.  Is there a way I can set it up to email me when somebody creates an account?
[20:10:29] <puff>	 Hm, I guess I could turn on account confirmation...
[21:25:47] <ashley>	 puff: have you considered [[mw:Extension:ConfirmAccount]]?