[06:25:19] Looks like semgrep got some money to spend on their static analysis tool https://www.fossjobs.net/jobs-at/r2c/ [06:26:32] Is there a built-in way to prevent users from removing their email address after registration? [13:06:34] Tpt: hey! can you have a look at a patch for ProofreadPage? We are moving logic out of the Content interface, and I'd like to avoid loading revisions from Content or ContentHandler. So we are moving isChangeAllowed check into a hook. But I'm not quite sure it'S doing exactly the right thing... Could you check it out? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ProofreadPage/+/734949 [13:55:53] duesen: Hi! I just did it. [17:46:57] if with $wgJobRunRate it doesn't run in a request... how is it fulfilled? [17:50:12] I don't quite understand how it works... it was apparently the cause of a ton of 'ghost' views... if the default is 1 does that mean it runs every second, resulting in 'views'? [17:50:50] eh? [17:50:58] !wg JobRunRate [17:50:58] https://www.mediawiki.org/wiki/Manual:%24wgJobRunRate [17:51:19] The details section explains what the config does [17:51:36] I read it, but doesn't quite answer my questions... [17:52:41] If it's the default value, it doesn't run every second, no [17:52:55] It means every request will (try to) execute a job queue job [17:53:07] If there's no requests, no jobs are executed [17:55:31] But presumably jobs are mostly when links are clicked? What reason would there be then if an unknown wiki gets, literally, tens of millions of views, which suddenly stop as soon as it's 0.01? [17:58:16] Well, a link being clicked will result in a page being loaded, and therefore a job being run [17:58:37] Depending on what extensions you have running, they may result in "views" if they do some processing... But by default, I doubt it does [17:58:47] What are you using to suggest the wiki is getting views? [18:00:00] "This page has been accessed" at the bottom, and special:stats, apparently a template on every page got the second most views after the main pain, so I assume it depends on how many links there are... [18:00:10] page* [18:01:24] It was overloading the server so much it wasn't letting me accessing the wiki half of the time... suddenly it's all fine... [18:01:42] Again, depending on what extensions are on your wiki... [18:01:49] It's possible there's a lot of jobs that need running [18:02:52] QuestyCaptcha perhaps? I think it got installed last before this happened. [18:03:13] I doubt it [18:03:46] The "This page has been accessed" is from the HitCounters extension [18:05:12] And IIRC HitCounters was basically removed from MW core because of performance reasons [18:05:34] I can't even find that in LocalSettings.php... [18:05:42] What version of MediaWiki are you using? [18:06:24] 1.22.6 [18:06:31] ... [18:06:44] That is very much an unsupported version [18:07:17] So even if there is some bug like you might be suggesting, it's not going to be fixed unless it's also present in some currently supported version of MW [18:07:33] Still not the reason it got millions of fake views, I assume... [18:08:59] * Reedy shrugs [18:09:24] Without knowing your full setup... [18:09:48] that HitCounters may very well have a bug, and it may be fixed in recent versions (or not) [18:10:06] That's old enough it's still HitCounter as part of MW core [18:11:08] if anyone else is curious, 1.22 went EOL in December 2014 [18:11:49] * Reedy grins [18:12:45] loftyabyss: You'd be very much advised to upgrade your wiki... For performance and security reasons [18:14:03] That's the year Microsoft Windows XP got EOL [18:14:43] I will, but... I kind of preferred the old logo, and it'd be gone... [18:15:08] You could've been on a much more recent version and still on the old logo [18:15:20] Considering that only happened "recently" too.. [18:16:10] The server running that installation is probably very outdated as well [18:26:37] Just noticed that with a dark screen the new logo looks somewhat like Opera's...