[08:55:12] pywikibot-room is not as responsive as this one, huh :) [12:51:54] Hello. I would imagine that https://www.mediawiki.org/wiki/Special:MyLanguage/Download listing 1.36.2 as “LTS” is a mistake, and the LTS is still 1.35.4 as per topic, that would be correct, no? Is there an official source other than the Wiki where I can confirm these? [12:54:38] That page and how we manage it is stupid [12:54:45] Yes, 1.35 is still a supported LTS [12:55:44] https://www.mediawiki.org/wiki/Template:MW_lts_branch_number [12:55:50] * Reedy scratches his head [12:57:51] yeah, it is [12:57:52] * MediaWiki {{MW legacy release number}} ({{MW legacy release link zip|1= download .zip}}, {{MW legacy release link|1= download .tar.gz}}) - current long-term support (LTS) [12:57:57] legacy release does not make it an LTS [13:04:03] hexnewbie: fixed [13:04:36] Thanks [13:04:53] For future reference, https://www.mediawiki.org/wiki/Version_lifecycle is probably the page you were looking for [16:33:24] Does anyone know why https://github.com/wikimedia/mediawiki/blob/23d5d441c9965ab21870e6977baa8c83001c01ee/maintenance/nukeNS.php#L93 can't be moved to after the loop? [16:34:05] That line seems to causing awful performance [16:36:41] And potential data loss [16:37:34] I mean, it's deleting potentially thousands of rows... [16:41:39] purgeRedundantText has a lot of issues if you search for it in https://phabricator.wikimedia.org/tag/mediawiki-maintenance-system/ [16:43:03] * Reedy pretends to be surprised [19:35:47] Reedy: https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/123773/console will fix the crappy script performance [19:36:00] https://gerrit.wikimedia.org/r/c/mediawiki/core/+/740165 [19:36:12] CI is failing though due to a GE issue [19:59:46] Reedy: Thanks for looking at T296103 and T295737. I'm happy to try to work on a patch for either if you can give me some pointers on what the behavior should be. [19:59:47] T295737: Install script doesn't validate that provided MySQL user has necessary privileges - https://phabricator.wikimedia.org/T295737 [19:59:47] T296103: Error message truncated in install script - https://phabricator.wikimedia.org/T296103 [20:04:16] I guess for T296103 we can just catch the error and emit it manually instead of relying on MWExceptionHandler::handleUncaughtException? [20:05:38] (i.e. wrap a try/catch around `performInstallation`) [20:45:22] Hello, I have a quick upgrade question: Can I upgrade from MediaWiki 1.31.0 to 1.37.0 or do I have to upgrade to 1.35.4 first and then from 1.35.4 to 1.37.0? Or do I even have to upgrade from 1.35.4 to 1.36 and then to 1.37.0? [20:46:31] I believe the release note indicates which version to use [20:47:38] Oldest you can upgrade from is 1.27 [20:48:33] SIlverSurfer: ^ [20:49:02] Ah, okay, thank you! The UPGRADES file says "Upgrading from releases older than two LTS release is not supported anymore." I wasn't sure what exactly counts as LTS. [20:49:12] UPGRADE* [20:49:46] LTS is every 4 releases [20:50:52] Cool, that's good to know! Thank you for your kind help and have a nice day! [20:52:27] Looks like it's mentioned on the line below [20:59:04] Oh, yeah, sorry, my bad. You're right! I totally missed that line. Looks like I'm a little tired from working all day. [20:59:30] Take care & stay healthy! Bye! [21:00:23] see also https://www.mediawiki.org/wiki/Version_lifecycle [21:18:11] Thank you! [22:34:15] Reedy: with https://gerrit.wikimedia.org/r/c/mediawiki/core/+/740165 applied, it made more progress in 1 minute than the 4 days without that change [22:35:39] I wonder if it's more the transaction or the loop [22:36:01] Reedy: no idea but that's an insane change [22:36:12] From that one line patch [22:36:34] That's 5760x faster [22:37:00] The code looks weird [22:37:17] Why is $this->beginTransaction( $dbw, __METHOD__ ) before the loop [22:37:42] But there's a $this->commitTransaction( $dbw, __METHOD__ ) in the nested delete... But never starting it again [22:38:29] That makes 0 sense [22:39:19] It looks to have been like that for 13 years [22:39:26] Not that it makes it right. Probably just that it's not used much [22:39:44] Yeah I can't imagine it used much [22:39:54] I need sleep [22:40:26] But I'm sure if you comment on the patch more can be added or upload a new PS [22:44:03] meh [22:44:06] seems we do this elswhere [22:46:21] but... [22:51:40] I can't decide if this is wrong, write, weird... [22:51:44] *right