[16:59:11] Reedy: is there an approx time to check my emails? [17:56:26] RhinosF1: Probably at latest an hour from now [17:56:33] Reedy: ok [17:56:54] * RhinosF1 thinks a really nice would be about 10pm so he could deploy from bed :) [17:57:01] go to bed early? :P [17:57:08] True :) [17:57:12] I likely will [17:57:18] Also, deploying from bed isn't adventurous... [17:57:35] Most of the prep is done, but I want to take a bit of a break before I sit shepherding CI [17:58:55] Reedy: how simple is the workaround to apply? [17:59:27] You can copy pasta 4 lines into your LocalSettings at the bottom [17:59:34] Okay good [17:59:36] Potentially less depending on your config [17:59:52] Most wikis probably only need two [18:00:03] You can always set the $wgReadOnly flag ;-) [18:01:11] service apache2 stop [18:01:37] better safe than sorry! [18:01:45] sudo shutdown now [18:06:42] shutdown? [18:06:46] sudo halt! [18:08:42] Unplugging server solves many issues [18:08:55] Would be no mem leak too if there was no process running [18:11:24] There we go! [18:11:28] collab problem solving [18:11:48] RhinosF1: btw, Tim has found a memleak issue in I think the PHP mysql driver [18:12:05] https://github.com/tstarling/php-src/commit/147b5009178cf12cc720b3e19c5ad0be713c2c33 [18:12:10] But that's only a backport to 7.2 [18:12:34] Not sure if it's related to you... Or what PHP versions afflicted [18:12:36] the fix was in 7.3 I believe [18:13:26] Probably not relevant to the issue they were seeing then [18:25:41] Reedy: I did see [18:26:00] We're 7.3 [18:26:10] s/7.3/7.4 [18:26:13] Affected [18:26:27] 7.3 was getting OOMs but far more rare [18:26:59] Well I saw all the discussion around the train [19:26:12] Where's our mail? o_O [19:28:15] Vulpix: I guess we convinced Reedy to shut down his laptop instead of doing the release [19:28:30] It's out [19:31:31] https://www.mediawiki.org/wiki/2021-12_security_release/FAQ [19:32:16] \o/ [19:32:21] Thank you all for your work. [19:52:39] the official but not-official docker images should be updated in a few minutes https://github.com/docker-library/official-images/pull/11521#issuecomment-995161662 [19:57:56] I needed to move vendor-folder away, but it seems when I run maintenance/update.php I still have the 1.35.4 updater, not 1.35.5. I thought I'd get the newest with 'git pull https://gerrit.wikimedia.org/r/mediawiki/core.git REL1_35'. Here is my procedure I've been using to upgrade minor releases https://paste.debian.net/1223620/ I'm probably doing something wrong [19:58:23] not all the patches have been merged into git yet [19:58:28] it takes a while for our CI to process them all [19:58:48] Reedy will probably say something in here once all the git tags are pushed [19:58:54] oh, ok, thanks legoktm [19:58:57] the security patches for 1.35 have landed, just not the administrivia ontop [19:59:49] so then you're probably OK because the incrementing of the version number is in that "administrivia" [20:01:38] ok, so I've upgraded my private test wiki, should I proceed to do the same for others and trust that the code is the newest REL1_35, even if the updater hasn't yet have the correct version number in it? [20:02:24] you can check via git log [20:02:25] look at your git log? :) [20:03:26] cheers [20:13:51] Iamthehuman1: if you pull again, you'll get the version number bump [20:13:57] (still no 1.35 tag pushed) [20:15:07] 1.35.5 is there now though [20:20:47] Thanks I see it now Reedy. Do I need to run the updater again on the wikis I already upgraded in order for Special:Version to show correct version ? [20:21:03] Nope [20:21:09] You don't need to run update.php at all for this update [20:21:10] Cool [20:21:16] (it won't harm either) [20:59:07] heya, the git guide says that I need to clone a repo called vendor.git to create the vendor directory in the root dir of the wiki installation, but after I cloned mediawiki itself and did 'git submodule update --init --recursive' I already have a vendor directory with lots of stuff in it. [20:59:23] is the cloning vendor.git step redundant now? (outdated instructions?) [21:02:14] Depends what "version" you cloned [21:02:20] master would need that, release branches would not [21:03:05] I see, thanks! indeed I checked out a release branch.