[14:08:41] Running importImages.php maintenance script to overwrite a bunch of images. I'm getting the error "overwriting...failed. (at recordUpload stage)" [14:08:44] What does this mean. [14:16:17] I'm gonna delete all the files and try from there. [14:19:20] Okay that's works. [14:19:44] I wonder about that recordUpload failure though 🤔 [14:19:57] this usually happens when you run the script with a different user than the web/php user running MediaWiki [14:20:53] Note that your files may now be created with your user account, and MediaWiki won't be able to rename, delete or overwrite them again... you should change the owner recursively afterwards [14:21:49] The correct way of running maintenance scripts is to run them as the same user account that runs php on the webserver. Usually by using the "sudo" command utility [14:28:44] I see. [14:30:28] I'm running Debian running mediawiki installed from apt. Not certain which user that is. Is it www-data (that's running apache I see) [14:30:51] I ran the script as root btw. [14:34:08] you can look the owner and group of files created by MediaWiki (for example, uploaded files) [14:49:37] Yeah its www-data [14:49:56] Or at least, presently a mish-mash of www-data and root (the files I've (re)uploaded) [15:04:28] you can do a chown -R www-data:www-data images/ [15:08:27] Yeah that's worked, thank you. [15:09:00] Had no immediate need to rename/modify the files I uploaded but that's given me peace of mind. [15:47:58] RhinosF1: sorry, I missed your message yesterday. The reason I kept +2'ing that patch is that that seemed to be the only way to get new versions of the patch to pass through validation again. [15:48:37] Yaron: you can use recheck or get them added the Zuul allowlist [15:48:53] I'm sure Re.edy would have done it [15:49:22] +2 is approved though, it would have been better to actually review and maybe help them run phpcs [15:50:18] What do you mean by "actually review"? [15:50:20] So they can learn and work on patches rather than constantly resubmit and slowly work through all about 25 issues patchset by patchset and use up computing power and reviewer time [15:51:03] Yaron: pressing +2 constantly on the same patch isn't helpful, you could have provided advice to them so they know how to improve, locally test and find out about code standards [15:52:03] I did provide advice... [15:53:26] I don't see it in the patch comments [15:53:51] That's true, not in the patch comments. [15:55:18] That's hard to see from the patch comments and on patch all me and zoranzoki seem to be seeing is you pressing +2 on a patch that isn't ready and not helping them learn the standards we follow [15:55:58] Right. [15:57:29] Where is this "recheck" link, by the way? I don't know if I've ever seen that. [15:59:59] Just type recheck as a comment [16:00:36] Oh... [16:00:41] I can show you how to get them on the zuul allowlist if you want so Jenkins runs straight away for them Yaron [16:03:20] Thanks - that would be good, actually. [16:08:15] Yaron: you just need to create a patch in intergration/config in https://github.com/wikimedia/integration-config/blob/master/zuul/layout.yaml#L104 [16:08:19] Via gerrit though [16:08:31] Not sure if anyone would be around today to reload [16:08:46] Sanjay's gerrit email will be on https://gerrit.wikimedia.org/r/q/owner:sanjayipscoc%2540gmail.com [16:11:15] RhinosF1: thanks a lot for that information. There's actually a few people I might try to add. [16:11:46] (see also https://www.mediawiki.org/wiki/Continuous_integration/Allow_list) [16:12:47] AntiComposite: thanks. [16:14:59] CR+1 should also run tests on an untested patch, without the danger of CR+2. But it's better to use recheck unless you actually intend the CR+1 [16:16:10] you can check that the jobs are running at https://integration.wikimedia.org/zuul/ [16:19:52] Doing a +1 seemed to have no effect, while doing a +2 almost immediately started up validation, for what it's worth. [16:20:48] That's not always the case, but it seemed to be for this extension (GoogleDocCreator, whose repository was just recently created). [16:24:50] it wasn't added to CI until Thu Dec 23 15:29:47 2021 +0000 [23:43:33] heya, I have the AutoSitemap extension enabled (shows in Version page) but it won't generate sitemap.xml when I create or edit a page. why might that be? any log files I can check?