[07:37:50] CindyCicaleseWMF: thanks for the patch [12:32:39] Hi! 1.36: I blocked and delete all their posts from about 100 Spambotaccounts. I then ran deleteArchivedRevisions.php and thought I could delete the users with removeUnusedAccounts.php but... nope, there are still entries from those deleted pages in the text and content tables? [12:34:57] That doesn't sound a complete surprise [12:35:32] deleteArchivedRevisions is for removing the deleted revisions... Not the page itself [12:36:23] Though you'd think it would actually clean up a little more [12:36:46] It does/should try to (at least in the code as of master) [12:37:04] Do you still have the output (use a pastebin) [12:38:13] https://pastebin.com/mV97DC4A [12:39:08] it says it also runs purgeOldText.php which "It will remove from the text table any records which are not linked to any existing or archived revision." [12:39:54] Yeah... Because of the 409 it should've [12:40:08] The "Searching for" are proof it ran (but that it didn't do anything) [12:44:03] I think "old text" is actually misleading [12:45:19] beob: Try running.... deleteOrphanedRevisions.php [12:45:39] yeah, I tried that as well: Checking for orphaned revisions...found 0. [12:45:41] Wait, no... [12:45:51] You need a version of that [12:46:31] * Reedy probably needs some caffeine [12:47:03] DeleteArchivedRevisions removes them from the archive table... So they're not restoreable [12:47:19] Did those pages only have one revision? [12:49:09] at least some of them, yes, I have one open with only the log entries: created & deleted [12:49:27] So I think that explains the behaviour then [12:49:49] The "delete old text" is looking for where the content rows are not the "latest"... And they still are (because they've not been cleaned up fully) [12:50:35] deleteOldRevisions.php may work if you can feed it the list of specific page ids to work on [12:51:20] T271635 [12:51:21] T271635: Bug: deleteArchivedRevisions.php does not remove rows in `content` and `text` tables - https://phabricator.wikimedia.org/T271635 [12:51:38] Ta-da [12:51:48] deleted pages are no longer in the page table, I could only find those entries in content (and then text) [12:52:13] oh, thanks Vulpix [12:52:45] I guess unless disk space is a major concern... don't worry? :P [12:53:25] it's not, more of a "look at those 1000 stupid accounts" issue :) [12:55:28] thank you for the help! [14:09:11] RhinosF1: you're welcome! [23:14:43] hi, I'm trying to use or update an old skin for mw 1.37, in the log I have reports of 'Use of Skin::makeUrl was deprecated in MediaWiki 1.36', but I don't understand what replaced it, can you help? [23:15:01] the skin is Erudite, running here if you want to see: https://free-astro.org/ [23:17:41] hi [23:17:52] release notes say "Skin::makeUrl() has been deprecated. Title methods should be used instead." [23:18:21] https://www.mediawiki.org/wiki/Release_notes/1.36 says ``Skin::makeUrl() has been deprecated. Title methods should be used instead.`` [23:18:54] see https://www.mediawiki.org/wiki/Manual:Title.php [23:19:29] is it ok to edit the release notes, AntiComposite ? i would like to link 'title methods' to [[Manual:Title.php]] [23:20:28] sure [23:21:15] done [23:21:15] obviously it would be a bad idea to reorganize the whole thing, because it would be out of sync with the plain-text copy in git, but adding links is fine [23:23:25] thanks, I didn't know what Title methods even meant [23:26:04] and as I know basically nothing about php, the line $this->getSkin()->makeUrl($i->rc_title); should be replaced by? (rc_title is the returned field, seems to be the title of recent pages list [23:30:20] is it newFromText($i->rc_title)->getFullUrl() maybe? [23:33:41] I don't have the warning any more and the site is still working so that must have been it, thanks